Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reload eager loaded classes after unloading classes due to reload #159

Merged
merged 4 commits into from
Jul 26, 2019
Merged

reload eager loaded classes after unloading classes due to reload #159

merged 4 commits into from
Jul 26, 2019

Conversation

tansengming
Copy link
Owner

@tansengming tansengming commented Jul 25, 2019 •
edited
Loading

fixes #155

thanks to @alexagranov for coming up with the initial fix at #156

the testing scenarios are listed on tansengming/stripe-rails-dummy#2

@tansengming tansengming mentioned this pull request Jul 25, 2019
Open
@tansengming tansengming mentioned this pull request Jul 25, 2019
Closed
@alexagranov
Copy link
Contributor

@tansengming this looks much better now 👌 thanks!

@tansengming tansengming merged commit b496228 into master Jul 26, 2019
@tansengming tansengming deleted the bug/eager-reload branch July 26, 2019 13:51
@tansengming tansengming mentioned this pull request Jul 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearing callbacks after unload doesn't play nice with eager_load settings in DEV
2 participants
@tansengming @alexagranov