Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate PEGTL tests when no filesystem is configured #351

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

uilianries
Copy link
Member

I merged the PR #350 to a new branch created from 3.x, and added a new new validation in Actions to check that we don't break tests when running without filesystem.

The filesystem has a specific test test_filesystem.cpp.in that should be activated only when PEGTL_USE_FILESYSTEM is active. So this new regression test checks in case we break something when changing filesystem.

Related to #350

ColinH and others added 2 commits July 10, 2023 10:59
Add a CMake option to select no std::filesystem
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@ColinH
Copy link
Member

ColinH commented Jul 10, 2023

Great, thanks, you can merge this in to the 3.x branch when you think it's ready, and I'll take care of removing the change and boost::filesystem support from the main branch RSN.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

@ColinH I see Github Action is failing due missing compilers. I'll take a look on this. It seems like the latest version of Ubuntu distributed by Github does not support older compiler versions.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf639f7) 99.70% compared to head (191fe2e) 99.70%.

❗ Current head 191fe2e differs from pull request most recent head 86a677a. Consider uploading reports for the commit 86a677a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##              3.x     #351   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         248      250    +2     
  Lines        5045     5096   +51     
=======================================
+ Hits         5030     5081   +51     
  Misses         15       15           

see 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@uilianries
Copy link
Member Author

Clang Tidy failed, but I'll ignore it for now, as it could be customized.

@uilianries uilianries merged commit 8d73e29 into taocpp:3.x Jul 10, 2023
68 of 69 checks passed
@uilianries uilianries deleted the testing/no-filesystem branch July 10, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants