-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sente retrying connection after disconnection #254
Comments
Hey Daniel, just to clarify what I'll be looking for-
That correct? This part is tripping me up:
Are you implying this only happens if you issue
Great, that'll be helpful. Will just wait for you to confirm what I'm looking for. Thanks, cheers :-) |
Just to confirm, you're not seeing a log message like I.e. no chance that what's happening is that the WebSocket->Ajax fallback is kicking in? (It shouldn't, but may be buggy). |
Nope, nothing about downgrading to ajax, and devtools shows a ws connection. The steps to reproduce are:
|
Thanks, this framing makes the problem immediately clear. The critical observation was 4 preceding 5. Will fix, thanks. |
In-flight (waiting) retries weren't checking handle ownership
In-flight (waiting) retries weren't checking handle ownership
Just pushed Would also be happy to accept a PR that brings the disconnect/reconnect buttons to the ref example. Thanks |
Sure thing, will look at both of your changes on Monday. Thanks! |
I can confirm that your commit fixes this. Thanks! |
I've noticed that when I disconnect a websocket connection when it is trying to connect, it makes one more reconnect attempt after the disconnect. I've attached a log below from the Sente example project showing this.
I've just pushed a branch https://github.com/ptaoussanis/sente/tree/reconnect-example which adds a disconnect and reconnect button in the example project for you to easily experiment with.
I've had a look at the reconnect code, and I can't quite figure out where the checks should go to stop this from happening.
The text was updated successfully, but these errors were encountered: