Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows release from tdengine/package/release.bat failed #20233

Merged
merged 2 commits into from Mar 2, 2023
Merged

fix: windows release from tdengine/package/release.bat failed #20233

merged 2 commits into from Mar 2, 2023

Conversation

facetosea
Copy link
Contributor

No description provided.

sangshuduo
sangshuduo suggested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@sangshuduo sangshuduo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "cusName" "cusPrompt" to align with other platform. use "TDengine" if it will show as brand name.

sangshuduo
sangshuduo approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@sangshuduo sangshuduo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangshuduo sangshuduo marked this pull request as ready for review March 2, 2023 02:34
@sangshuduo sangshuduo merged commit b1cdb4f into 3.0 Mar 2, 2023
@gccgdb1234 gccgdb1234 deleted the FIX/xsren/windowCommnityRelease3.0 branch March 8, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangshuduo sangshuduo sangshuduo approved these changes

@xleili xleili Awaiting requested review from xleili

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@facetosea @sangshuduo