Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs for assignment and seek #21658

Merged
merged 2 commits into from Jun 9, 2023

Conversation

sunpe
Copy link
Contributor

@sunpe sunpe commented Jun 8, 2023

No description provided.

@sunpe sunpe requested a review from gccgdb1234 June 8, 2023 06:44
@@ -453,6 +453,44 @@ As the way to connect introduced above but add `req_id` argument.
</TabItem>
</Tabs>

### Subscription
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对订阅相关的 API 要有基本的说明,然后才是示例代码综合展示如何使用。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以中文版的 459 到464 行的两处引用为例,对 Python 连接器自己 的 API 没有任何说明,所引用的文档也没有参考价值,应该去除。这一部分应该这么修改:

  1. 去除对 develop/subscription 的引用
  2. 列举并详细说明 Python 连接器中与 订阅有关的 API
  3. 在以上的基础上,最后才是示例代码

英文版有相同的问题。

@gccgdb1234 gccgdb1234 self-requested a review June 9, 2023 04:00
@gccgdb1234 gccgdb1234 merged commit e3f5766 into 3.0 Jun 9, 2023
1 check passed
@sunpe sunpe deleted the docs/sunpeng/TD-24607-docs-for-assignment-and-seek branch June 27, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants