fix: fix non-root users cannot create log files even if they have write #22458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permission of the directory
dapan1121
reviewed
Aug 22, 2023
source/os/src/osDir.c
Outdated
| @@ -206,7 +206,11 @@ int32_t taosMulModeMkDir(const char *dirname, int mode) { | |||
| #endif | |||
|
|
|||
| if (taosDirExist(temp)) { | |||
| return chmod(temp, mode); | |||
| if (taosCheckAccessFile(temp, TD_FILE_ACCESS_WRITE_OK)) { | |||
There was a problem hiding this comment.
两个问题：
- taosMulModeMkDir 这个函数是个底层通用函数，不能因为日志的用法就改变这个函数的含义；
- 对日志来说，需要能读、写、创建文件，TD_FILE_ACCESS_WRITE_OK是否足够？有没有实际测试一下？
There was a problem hiding this comment.
- 单独添加函数用于写日志
- 经过测试，非同一个group的用户创建的目录，当前用户还是需要具有W/R/E 三个权限保证日志功能正常执行，已添加对三个权限的检测。
dapan1121
reviewed
Aug 28, 2023
| @@ -206,6 +206,9 @@ int32_t taosMulModeMkDir(const char *dirname, int mode) { | |||
| #endif | |||
|
|
|||
| if (taosDirExist(temp)) { | |||
| if (checkAccess && taosCheckAccessFile(temp, TD_FILE_ACCESS_EXIST_OK | TD_FILE_ACCESS_READ_OK | TD_FILE_ACCESS_WRITE_OK)) { | |||
dapan1121
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
permission of the directory