feat: optimize partition node, replace with sort node #22629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangjiaming0909
force-pushed
the
feat/TD-25620
branch
3 times, most recently
from
ee9b9cf
to
dc77d93
Compare
dapan1121
reviewed
Sep 1, 2023
| if (!pGroupIdCalc->lastKeyBuf) code = TSDB_CODE_OUT_OF_MEMORY; | ||
| } | ||
| if (TSDB_CODE_SUCCESS == code) { | ||
| pInfo->pGroupIdCalc = pGroupIdCalc; |
wangjiaming0909
force-pushed
the
feat/TD-25620
branch
from
dc77d93
to
72335c7
Compare
wangjiaming0909
force-pushed
the
feat/TD-25620
branch
2 times, most recently
from
217c0ce
to
e3d78ab
Compare
dapan1121
reviewed
Sep 13, 2023
|
|
||
| int32_t blockDataGetSortedRows(SSDataBlock* pDataBlock, SArray* pOrderInfo) { | ||
| if (!pDataBlock || !pOrderInfo) return 0; | ||
| for (int32_t i = 0; i < taosArrayGetSize(pOrderInfo); ++i) { |
There was a problem hiding this comment.
这里是因为目前只有一列吗，要不这个逻辑就不对了吧
| if (!pOrder) { | ||
| code = TSDB_CODE_OUT_OF_MEMORY; | ||
| } else { | ||
| pSort->excludePkCol = true; |
There was a problem hiding this comment.
如果已经存在primary ts列，可以不加新列，excluedPkCol也不需要了
| @@ -34,6 +34,7 @@ | |||
| ,,y,system-test,./pytest.sh python3 ./test.py -f 2-query/nestedQuery_time.py -Q 4 | |||
| ,,y,system-test,./pytest.sh python3 ./test.py -f 2-query/nestedQuery_26.py -Q 4 | |||
| ,,y,system-test,./pytest.sh python3 ./test.py -f 2-query/interval_limit_opt.py -Q 4 | |||
| ,,y,system-test,./pytest.sh python3 ./test.py -f 2-query/partition_by_col.py -Q 4 | |||
There was a problem hiding this comment.
我们有几种查询policy，-Q 4只是其中一种，加一个新文件应该是类似这样加：
,,y,system-test,./pytest.sh python3 ./test.py -f 2-query/columnLenUpdated.py
,,y,system-test,./pytest.sh python3 ./test.py -f 2-query/columnLenUpdated.py -Q 2
,,y,system-test,./pytest.sh python3 ./test.py -f 2-query/columnLenUpdated.py -Q 3
,,y,system-test,./pytest.sh python3 ./test.py -f 2-query/columnLenUpdated.py -Q 4
wangjiaming0909
force-pushed
the
feat/TD-25620
branch
2 times, most recently
from
9ceebeb
to
12ffdbd
Compare
wangjiaming0909
force-pushed
the
feat/TD-25620
branch
from
12ffdbd
to
cb78c54
Compare
dapan1121
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.