enh: exclude sys tables in log/audit db #23135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapan1121
reviewed
Oct 7, 2023
| @@ -98,6 +98,9 @@ typedef struct SQueryNode SQueryNode; | |||
| #define VND_INFO_FNAME "vnode.json" | |||
| #define VND_INFO_FNAME_TMP "vnode_tmp.json" | |||
|
|
|||
| #define TK_LOG_STB_NUM 19 | |||
There was a problem hiding this comment.
这里的个数是tkLogStb的表个数吧，直接定义成sizeof(tkLogStb)/sizeof(tkLogStb[0])更好维护一点吧
dapan1121
reviewed
Oct 7, 2023
| int64_t ctbNum; | ||
| metaGetStbStats(pMeta->pVnode, pReq->suid, &ctbNum, NULL); | ||
| pMeta->pVnode->config.vndStats.numOfTimeSeries += (ctbNum * deltaCol); | ||
| metaTimeSeriesNotifyCheck(pMeta); |
There was a problem hiding this comment.
metaTimeSeriesNotifyCheck 为什么是在alterStable检查而不是dropStable？
There was a problem hiding this comment.
1） dropStable 时已经有秒级的 statusReq 的同步，所以没有进行 check。2） alter stable 时，实际上只有 add column 时 metaTimeSeriesNotifyCheck 即可，drop column 有秒级的 statusReq 也够用了，只是没做详细的区分。
dapan1121
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.