Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed never-read inErrorState from index.js #462

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Removed never-read inErrorState from index.js #462

merged 1 commit into from
Mar 4, 2019

Conversation

JoshuaKGoldberg
Copy link
Contributor

Fixes #461.

@ljharb
Copy link
Collaborator

ljharb commented Mar 4, 2019

This seems to have been added in 9c60d32 / #127, and then not properly cleaned up in e3f9d01 / #138.

(note, for future reference, there's no need to create an issue for stuff like this :-) )

ljharb
ljharb approved these changes Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit c481dae into tape-testing:master Mar 4, 2019
@JoshuaKGoldberg JoshuaKGoldberg deleted the patch-1 branch March 4, 2019 02:09
ljharb added a commit that referenced this pull request May 25, 2019
@ljharb
v4.10.2
2c6818a 
 - [fix] don't consider 'ok' of todo tests in exit code (#470)
 - [refactor] Removed never-read inErrorState from index.js (#462)
 - [deps] update `glob`, `resolve`
 - [docs] Minor punctuation/highlighting improvement (#468)
@snyk-bot snyk-bot mentioned this pull request Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoshuaKGoldberg @ljharb