Remove uncaught-exception listener #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit removed the uncaught exception interception. However that code was needed to get the process to write the uncaught stack trace on failures. Since messing with uncaught exception messes with the way we exit the only way to know if exit is called from uncaught exception is to monkey patch node core and keep track of the state
|
If no one objects to this change then I will land it. |
|
cc @substack et al. |
Raynos
added a commit
that referenced
this pull request
Jan 15, 2015
Remove uncaught-exception listener
vvo
pushed a commit
to defunctzombie/zuul
that referenced
this pull request
Jul 1, 2015
+ add browser_output_timeout option, default to no timeout like before So that cloud testing does not hangs when uncaught exception thrown or any other funny thing Related to (but also useful for anyone) tape-testing/tape#127 and tape-testing/tape#134 This fixes #185 + add browser_retries option, default to 6 like before + some more debugging information to ease .. debugging
ngryman
pushed a commit
to ngryman/zuul
that referenced
this pull request
Jul 19, 2015
+ add browser_output_timeout option, default to no timeout like before So that cloud testing does not hangs when uncaught exception thrown or any other funny thing Related to (but also useful for anyone) tape-testing/tape#127 and tape-testing/tape#134 This fixes defunctzombie#185 + add browser_retries option, default to 6 like before + some more debugging information to ease .. debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A testing library should not have an uncaught-exception listener, it makes testing hard code like uncaught exceptions harder.
For example
`
Tape intercepts my range error and ruins the stack by rethrowing.
The particular PIPE bug we were gaurding against is better dealt with by adding
an error listener on
process.stdoutor something.Not really sure which EPIPE we are gaurding against. I recommend removing it
for now and we can add it back later.