Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eslint package #377

Merged
merged 3 commits into from
Nov 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/embed/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module.exports = {
root: true,
extends: ['weblint'],
ignorePatterns: ['/src/types/lens.ts']
}
30 changes: 0 additions & 30 deletions apps/embed/.eslintrc.json

This file was deleted.

7 changes: 1 addition & 6 deletions apps/embed/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,12 @@
"react-icons": "^4.6.0"
},
"devDependencies": {
"eslint-config-weblint": "*",
"@types/mixpanel-browser": "^2.38.0",
"@types/node": "18.11.9",
"@types/react": "18.0.25",
"@types/react-dom": "18.0.9",
"@typescript-eslint/eslint-plugin": "^5.43.0",
"autoprefixer": "^10.4.13",
"eslint": "8.27.0",
"eslint-config-next": "13.0.4",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-simple-import-sort": "^8.0.0",
"eslint-plugin-unused-imports": "^2.0.0",
"postcss": "^8.4.19",
"prettier": "^2.7.1",
"tailwindcss": "^3.2.4",
Expand Down
3 changes: 2 additions & 1 deletion apps/embed/src/components/MetaTags.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import {
} from '@utils/constants'
import Head from 'next/head'
import { useRouter } from 'next/router'
import React, { FC } from 'react'
import type { FC } from 'react'
import React from 'react'

type Props = {
title?: string
Expand Down
2 changes: 1 addition & 1 deletion apps/embed/src/components/PlayerContextMenu.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { LENSTUBE_URL } from '@utils/constants'
import useCopyToClipboard from '@utils/hooks/useCopyToClipboard'
import useOutsideClick from '@utils/hooks/useOutsideClick'
import { forwardRef, useRef } from 'react'
import React, { forwardRef, useRef } from 'react'
import toast from 'react-hot-toast'
import { AiOutlineLink } from 'react-icons/ai'
import { BiCheck } from 'react-icons/bi'
Expand Down
5 changes: 3 additions & 2 deletions apps/embed/src/components/Video.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ import { sanitizeIpfsUrl } from '@utils/functions/sanitizeIpfsUrl'
import truncate from '@utils/functions/truncate'
import { Mixpanel, TRACK } from '@utils/track'
import dynamic from 'next/dynamic'
import { FC, useEffect } from 'react'
import { LenstubePublication } from 'src/types/local'
import type { FC } from 'react'
import React, { useEffect } from 'react'
import type { LenstubePublication } from 'src/types/local'

import MetaTags from './MetaTags'

Expand Down
5 changes: 3 additions & 2 deletions apps/embed/src/components/VideoOverlay.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import { LENSTUBE_URL } from '@utils/constants'
import getProfilePicture from '@utils/functions/getProfilePicture'
import Link from 'next/link'
import { FC } from 'react'
import { LenstubePublication } from 'src/types/local'
import type { FC } from 'react'
import React from 'react'
import type { LenstubePublication } from 'src/types/local'

type Props = {
video: LenstubePublication
Expand Down
6 changes: 3 additions & 3 deletions apps/embed/src/components/VideoPlayer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import {
Video
} from '@vime/react'
import clsx from 'clsx'
import React, { FC, Ref, useEffect, useRef, useState } from 'react'
import { HLSData } from 'src/types/local'
import { LenstubePublication } from 'src/types/local'
import type { FC, Ref } from 'react'
import React, { useEffect, useRef, useState } from 'react'
import type { HLSData, LenstubePublication } from 'src/types/local'

import PlayerContextMenu from './PlayerContextMenu'
import SensitiveWarning from './SensitiveWarning'
Expand Down
4 changes: 2 additions & 2 deletions apps/embed/src/pages/[pubId].tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import Video from '@components/Video'
import { LENSTUBE_APP_ID, LENSTUBE_BYTE_APP_ID } from '@utils/constants'
import { GetServerSideProps } from 'next'
import type { GetServerSideProps } from 'next'
import apolloNodeClient from 'src/gql/apollo'
import { VIDEO_DETAIL_QUERY } from 'src/gql/queries'
import { LenstubePublication } from 'src/types/local'
import type { LenstubePublication } from 'src/types/local'

export default Video

Expand Down
1 change: 1 addition & 0 deletions apps/embed/src/pages/_app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import '@vime/core/themes/default.css'
import { MIXPANEL_API_HOST, MIXPANEL_TOKEN } from '@utils/constants'
import mixpanel from 'mixpanel-browser'
import type { AppProps } from 'next/app'
import React from 'react'

function MyApp({ Component, pageProps }: AppProps) {
if (MIXPANEL_TOKEN) {
Expand Down
File renamed without changes.
40 changes: 20 additions & 20 deletions apps/embed/src/types/local.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {
import type {
Attribute,
Comment,
FeeCollectModuleSettings,
Expand All @@ -9,7 +9,7 @@ import {
Post,
RevertCollectModuleSettings,
TimedFeeCollectModuleSettings
} from '.'
} from './lens'

export type VideoDraft = {
preview: string
Expand All @@ -24,6 +24,20 @@ export type FileReaderStreamType = NodeJS.ReadableStream & {
lastModified: string
}

export type CollectModuleType = {
isTimedFeeCollect?: boolean
isFreeCollect?: boolean
isFeeCollect?: boolean
isRevertCollect?: boolean
isLimitedFeeCollect?: boolean
isLimitedTimeFeeCollect?: boolean
amount?: { currency?: string; value: string }
referralFee?: number
collectLimit?: string
followerOnlyCollect?: boolean
recipient?: string
}

export type UploadedVideo = {
stream: FileReaderStreamType | null
preview: string
Expand All @@ -48,18 +62,10 @@ export type UploadedVideo = {
isNSFWThumbnail: boolean
}

export type CollectModuleType = {
isTimedFeeCollect?: boolean
isFreeCollect?: boolean
isFeeCollect?: boolean
isRevertCollect?: boolean
isLimitedFeeCollect?: boolean
isLimitedTimeFeeCollect?: boolean
amount?: { currency?: string; value: string }
referralFee?: number
collectLimit?: string
followerOnlyCollect?: boolean
recipient?: string
export type HLSData = {
hrn: string
url: string
type: string
}

export type LenstubePublication = Post & Comment & Mirror & { hls: HLSData }
Expand All @@ -69,12 +75,6 @@ export type IPFSUploadResult = {
type: string
}

export type HLSData = {
hrn: string
url: string
type: string
}

export type VideoUploadForm = {
videoThumbnail: IPFSUploadResult | null
videoSource: string | null
Expand Down
2 changes: 1 addition & 1 deletion apps/embed/src/utils/functions/getIsSensitiveContent.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { SENSITIVE_CONTENT } from '@utils/data/sensitives'
import { MetadataOutput } from 'src/types'
import type { MetadataOutput } from 'src/types/lens'

export const getIsSensitiveContent = (
metadata: MetadataOutput | null,
Expand Down
2 changes: 1 addition & 1 deletion apps/embed/src/utils/functions/getProfilePicture.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable @typescript-eslint/ban-ts-comment */
import { Profile } from 'src/types'
import type { Profile } from 'src/types/lens'

import { getIsDicebearImage } from './getIsDicebearImage'
import { getRandomProfilePicture } from './getRandomProfilePicture'
Expand Down
2 changes: 1 addition & 1 deletion apps/embed/src/utils/functions/getThumbnailUrl.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { STATIC_ASSETS } from '@utils/constants'
import { LenstubePublication } from 'src/types/local'
import type { LenstubePublication } from 'src/types/local'

import { sanitizeIpfsUrl } from './sanitizeIpfsUrl'

Expand Down
2 changes: 1 addition & 1 deletion apps/embed/src/utils/functions/getVideoUrl.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { LenstubePublication } from 'src/types/local'
import type { LenstubePublication } from 'src/types/local'

import { sanitizeIpfsUrl } from './sanitizeIpfsUrl'

Expand Down
3 changes: 2 additions & 1 deletion apps/embed/src/utils/hooks/useOutsideClick.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { RefObject, useEffect } from 'react'
import type { RefObject } from 'react'
import { useEffect } from 'react'

type AnyEvent = MouseEvent | TouchEvent

Expand Down
3 changes: 2 additions & 1 deletion apps/embed/src/utils/track.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import mixpanel, { Dict } from 'mixpanel-browser'
import type { Dict } from 'mixpanel-browser'
import mixpanel from 'mixpanel-browser'

import { IS_MAINNET, MIXPANEL_TOKEN } from './constants'

Expand Down
5 changes: 5 additions & 0 deletions apps/web/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module.exports = {
root: true,
extends: ['weblint'],
ignorePatterns: ['/src/types/lens.ts']
}
9 changes: 1 addition & 8 deletions apps/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"zustand": "^4.1.4"
},
"devDependencies": {
"eslint-config-weblint": "*",
"@graphql-codegen/cli": "^2.13.11",
"@graphql-codegen/fragment-matcher": "^3.3.1",
"@graphql-codegen/typed-document-node": "^2.3.7",
Expand All @@ -63,16 +64,8 @@
"@types/react-dom": "18.0.9",
"@types/react-mentions": "^4.1.7",
"@types/uuid": "^8.3.4",
"@typescript-eslint/eslint-plugin": "^5.43.0",
"autoprefixer": "^10.4.13",
"eslint": "8.27.0",
"eslint-config-next": "13.0.3",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-simple-import-sort": "^8.0.0",
"eslint-plugin-unicorn": "^44.0.2",
"eslint-plugin-unused-imports": "^2.0.0",
"postcss": "^8.4.19",
"prettier": "^2.7.1",
"tailwindcss": "^3.2.4",
"typescript": "4.9.3"
}
Expand Down
1 change: 0 additions & 1 deletion apps/web/src/utils/functions/getCoverPicture.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/ban-ts-comment */
import { STATIC_ASSETS } from '@utils/constants'
import type { Profile } from 'src/types/lens'

Expand Down
1 change: 0 additions & 1 deletion apps/web/src/utils/functions/getProfilePicture.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/ban-ts-comment */
import type { Profile } from 'src/types/lens'

import { getIsDicebearImage } from './getIsDicebearImage'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
{
"parser": "@typescript-eslint/parser",
"env": {
"es2022": true
module.exports = {
parser: "@typescript-eslint/parser",
env: {
es2022: true,
},
"parserOptions": {
"ecmaVersion": "latest",
"sourceType": "module"
parserOptions: {
ecmaVersion: "latest",
sourceType: "module",
},
"plugins": [
plugins: [
"@typescript-eslint",
"unused-imports",
"simple-import-sort",
"prettier",
"unicorn"
"unicorn",
],
"extends": ["next", "next/core-web-vitals"],
"rules": {
"prettier/prettier": ["error", { "endOfLine": "auto" }],
"import/no-duplicates": ["error", { "considerQueryString": true }],
extends: ["next", "next/core-web-vitals"],
rules: {
"prettier/prettier": ["error", { endOfLine: "auto" }],
"import/no-duplicates": ["error", { considerQueryString: true }],
"react/prop-types": "off",
"react/no-unescaped-entities": "off",
"react/jsx-no-useless-fragment": 2,
Expand All @@ -35,7 +35,6 @@
"simple-import-sort/exports": "error",
"jsx-a11y/role-supports-aria-props": "off",
"unicorn/no-lonely-if": "error",
"unicorn/no-useless-undefined": "error"
"unicorn/no-useless-undefined": "error",
},
"ignorePatterns": ["/src/types/lens.ts"]
}
};
18 changes: 18 additions & 0 deletions packages/eslint-config-weblint/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"name": "eslint-config-weblint",
"main": "index.js",
"version": "0.0.0",
"dependencies": {
"eslint": "8.27.0",
"eslint-config-next": "13.0.3",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-simple-import-sort": "^8.0.0",
"eslint-plugin-unicorn": "^44.0.2",
"eslint-plugin-unused-imports": "^2.0.0",
"prettier": "^2.7.1",
"@typescript-eslint/eslint-plugin": "^5.43.0"
},
"publishConfig": {
"access": "public"
}
}
5 changes: 0 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9425,11 +9425,6 @@ typedarray-to-buffer@3.1.5, typedarray-to-buffer@^3.0.4:
dependencies:
is-typedarray "^1.0.0"

typescript@4.8.4:
version "4.8.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.8.4.tgz#c464abca159669597be5f96b8943500b238e60e6"
integrity sha512-QCh+85mCy+h0IGff8r5XWzOVSbBO+KfeYrMQh7NJ58QujwcE22u+NUSmUxqF+un70P9GXKxa2HCNiTTMJknyjQ==

typescript@4.9.3:
version "4.9.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.3.tgz#3aea307c1746b8c384435d8ac36b8a2e580d85db"
Expand Down