Skip to content

Commit

Permalink
feat: require Node 6
Browse files Browse the repository at this point in the history
BREAKING CHANGE: drops support for older versions of Node.js.
  • Loading branch information
demurgos authored and bcoe committed Sep 20, 2018
1 parent f8d9b5a commit 9449c40
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 15 deletions.
7 changes: 3 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
sudo: false
language: node_js
node_js:
- '0.10'
- '0.12'
- '4'
- '5'
- '6'
- '8'
- '10'
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changes

## Unreleased

* BREAKING CHANGE: Require Node 6

## v1.5.6

Expand Down
6 changes: 3 additions & 3 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
environment:
matrix:
- nodejs_version: '5'
- nodejs_version: '4'
- nodejs_version: '0.12'
- nodejs_version: '6'
- nodejs_version: '8'
- nodejs_version: '10'
install:
- ps: Install-Product node $env:nodejs_version
- set CI=true
Expand Down
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "1.5.6",
"description": "Run a child as if it's the foreground process. Give it stdio. Exit when it exits.",
"main": "index.js",
"directories": {
"test": "test"
"engines": {
"node": ">=6.0.0"
},
"dependencies": {
"cross-spawn": "^4",
Expand All @@ -28,6 +28,9 @@
"url": "https://github.com/tapjs/foreground-child/issues"
},
"homepage": "https://github.com/tapjs/foreground-child#readme",
"directories": {
"test": "test"
},
"files": [
"index.js"
]
Expand Down
7 changes: 1 addition & 6 deletions test/basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ t.test('exit codes', function (t) {
t.end()
})

t.test('parent emits exit when SIGTERMed', { skip: isZero10OnTravis() || winSignals() }, function (t) {
t.test('parent emits exit when SIGTERMed', { skip: winSignals() }, function (t) {
var which = ['parent', 'child', 'nobody']
which.forEach(function (who) {
t.test('SIGTERM ' + who, function (t) {
Expand Down Expand Up @@ -181,11 +181,6 @@ t.test('IPC forwarding', function (t) {
})
})

function isZero10OnTravis () {
return process.env.TRAVIS && /^v0\.10\.[0-9]+$/.test(process.version) ?
'skip on 0.10 on Travis' : false
}

function winSignals () {
return process.platform === 'win32' ?
'windows does not support unix signals' : false
Expand Down

0 comments on commit 9449c40

Please sign in to comment.