Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #23

Merged
merged 1 commit into from
Sep 20, 2018
Merged

chore: update dependencies #23

merged 1 commit into from
Sep 20, 2018

Conversation

demurgos
Copy link
Contributor

@demurgos demurgos commented Sep 18, 2018

Why

The current dependencies have some vulnerabilities. It's also general good practice to keep the dependencies up to date.
npm also added support for lock files, a feature enabling reproducible builds.

What

  • Update dependencies to latest version
  • Add package-lock.json

Comments

The new versions of the dependencies add a transitive dependency on Node 4+ (both cross-spawn and tap).

Other

@demurgos demurgos force-pushed the update-deps branch 2 times, most recently from 7666eb9 to 48bd215 Compare September 19, 2018 06:23
@demurgos demurgos changed the title Update dependencies chore: update dependencies Sep 19, 2018
@demurgos
Copy link
Contributor Author

demurgos commented Sep 19, 2018

CI is failing on old Node versions, it is fixed in #24.

@bcoe
Copy link
Member

bcoe commented Sep 20, 2018

@demurgos mind rebasing your various pulls, and we can see if tests pass?

# Why

The current dependencies have some vulnerabilities. It's also general good practice to keep the dependencies up to date.
`npm` also added support for lock files, a feature enabling reproducible builds.

# What

- Update dependencies to latest version
- Add `package-lock.json`

# Comments

The new versions of the dependencies add a transitive dependency on Node 4+ (both `cross-spawn` and `tap`).

# Other

- Closes tapjs#13
- Closes tapjs#14
- Closes tapjs#15
- Closes tapjs#16
- Closes tapjs#17
- Closes tapjs#18
- Closes tapjs#19
@demurgos
Copy link
Contributor Author

@bcoe Done

@bcoe bcoe merged commit 68ad56a into tapjs:master Sep 20, 2018
@demurgos demurgos deleted the update-deps branch September 20, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants