Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies update coordination #38

Closed
5 of 11 tasks
demurgos opened this issue Oct 10, 2018 · 4 comments
Closed
5 of 11 tasks

Dependencies update coordination #38

demurgos opened this issue Oct 10, 2018 · 4 comments

Comments

@demurgos
Copy link
Contributor

demurgos commented Oct 10, 2018

Following #31 and discussions with @bcoe, I plan to release a coverage based on different design decisions: using spawn-wrap, the inspector API and AST. To achieve this, I need to introduce updates to some dependencies. My high-level needs are stronger encapsulation and type annotations.

The goal is not to fork the dependencies but discuss my changes and try to merge them so they can benefit to everyone. I already know the end result I'd like to have, but did a large amount of refactoring to make the libraries more maintainable. Sending these end-results in block is overwhelming to [review] (and kinda rude) so I am planning to merge the changes gradually, sending small PRs, and discussing each of them. This is a long process across multiple repos. The goal of this issue is to keep track of these various PRs.

signal-exit

foreground-child

(more to come)

spawn-wrap

(more to come)

@profnandaa
Copy link
Contributor

cc. @bcoe

@profnandaa
Copy link
Contributor

@demurgos - I have reviewed all and approved, waiting for Ben to check and merge.

@demurgos
Copy link
Contributor Author

Hi,
I discussed with @bcoe: unfortunately he does not have much time for OSS currently but redirected me to @isaacs and @addaleax. Could one of you look at these PRs? @profnandaa already reviewed most of them and I took care to keep them simple.

I am almost done with my own coverage tool (see #31 ) but I really need some fixes. I am currently using my own forks but this is not an ideal solution.

I am available on the node-tooling Slack to discuss these PRs more easily.

@bcoe
Copy link
Owner

bcoe commented Oct 24, 2019

Please feel free to reopen if there's any continued work you'd like to do around this 👍

We've been inactive for quite some time, so going to close for now.

@bcoe bcoe closed this as completed Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants