fix: do not break if global.process missing #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/no-process
branch
from
770c21b
to
4fdb3e2
Compare
isaacs
force-pushed
the
isaacs/no-process
branch
from
4fdb3e2
to
4fbeda8
Compare
coreyfarrell
approved these changes
Sep 21, 2021
isaacs
force-pushed
the
isaacs/no-process
branch
from
4855bf4
to
895665c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to fix the same shortcoming in node-tap, so that tap can be compiled for use in browsers, electron, and other environments where
processis not set.Some features that rely on
global.processproperties are degraded, of course, with reasonable fallbacks and useful errors where appropriate.