-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What should be considered "internal"? #8
Comments
What if we go for whitelist approach? Consider "internal" everything but project's folder (excluding node_modules, ofc). |
I think that should be up to the individual test runner. All of node_modules doesn't help trace down bugs in the modules I use (or help me understand how I'm misusing them). If they want to eliminate The spawn-wrap suggestion is an exception to that rule. But one I thought worth debating (especially since |
I just don't want to go overboard. It hurts users more to hide a valuable line than it does to repeatedly show them a useless one. I think we should only be deleting lines if we are near certain it's unimportant to the user. |
👍 for hiding all your suggested lines. |
Also swaps `[0-9]` for `\d` everywhere. Fixes #8.
Also swaps `[0-9]` for `\d` everywhere. Fixes #8.
The current list of regular-expressions doesn't capture everything I think it should.
The
internal
folder in Nodejs./\(internal\/[\w_-]+\.js:[0-9]+:[0-9]+\)$/
Note this matches the opening
(
, so it should not match user folders calledinternal
.Any
native
methods./\(native\)$/
Without this, I was getting long-stack-output with the following:
Which is pretty much useless.
Spawn wrap
/[\\\/]\.node-spawn-wrap-\w+-\w+[\\\/]node:[0-9]+:[0-9]+\)?$/
My thought is the only people who need to see spawn wrap output is spawn wrap developers. It doesn't technically qualify as an Nodejs internal, but it's wrapping/replacing internals, and it seems really unlikely to benefit anyone.
node.js
/node\.js:[0-9]+:[0-9]+\)?$/
This was appearing at the tail end of a lot of stack-traces in
long-stack-trace
test suite. I think it should probably match the opening(
like1
.The text was updated successfully, but these errors were encountered: