Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum for inner API to determine proxy options #422

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Use enum for inner API to determine proxy options #422

merged 3 commits into from
Sep 13, 2023

Conversation

nickkkccc
Copy link
Contributor

@nickkkccc nickkkccc commented Sep 12, 2023 •
edited
Loading

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:

Closes #420

@nickkkccc
Add ProxyOption enum class
278544a 
Add general enum class for using CRUD option names.

Needed for #420.
@nickkkccc
Change inner API for proxy options
571d334 
- Delete NAME field from Mode, RollbackOnError, StopOnError classes.
- Change inner API in OperationWith, Options interfaces, ProxySelectOptions, BaseOptions classes for using ProxyOption enum.
- Change Map to EnumMap in BaseOptions class.

Needed for #420.
@nickkkccc nickkkccc linked an issue Sep 12, 2023 that may be closed by this pull request
Use enum for inner API to determine proxy options #420
Closed
ArtDu
ArtDu reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@ArtDu ArtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing I can suggest now is adding changes in changelog about this PR. You can add below an internal changes header

@nickkkccc
Change inner API for CRUD options classes
dffd38f 
- Change inner API for CRUD options classes from working with ProxyOption enum class.
- Change CHANGELOG.md.

Closes for #420.
@nickkkccc nickkkccc self-assigned this Sep 13, 2023
@nickkkccc nickkkccc added this pull request to the merge queue Sep 13, 2023
Merged via the queue into master with commit b743fe5 Sep 13, 2023
3 checks passed
@nickkkccc nickkkccc deleted the gh-420 branch September 13, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtDu ArtDu ArtDu approved these changes

@akudiyar akudiyar Awaiting requested review from akudiyar

@iDneprov iDneprov Awaiting requested review from iDneprov

Assignees

@nickkkccc nickkkccc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use enum for inner API to determine proxy options
2 participants
@nickkkccc @ArtDu