crud: add execution access to a VShard user #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-366-vshard-user-experience
branch
2 times, most recently
from
bf1e833
to
07b9469
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-366-vshard-user-experience
branch
6 times, most recently
from
e905a99
to
10db835
Compare
test/unit/not_initialized_test.lua
Outdated
| pgroup.test_no_vshard_storage_cfg = function(g) | ||
| t.assert_error_msg_contains('vshard.storage.cfg() must be called first', function() | ||
| g.test_server:exec(function() | ||
| box.cfg({}) |
There was a problem hiding this comment.
If you are able to exec, it is likely to be already configured
DifferentialOrange
approved these changes
Oct 16, 2023
The patch adds execution access on a stroage for crud functions to a VShard storage user in the VShard manner [1]. 1. https://github.com/tarantool/vshard/blob/b3c27b32637863e9a03503e641bb7c8c69779a00/vshard/storage/init.lua#L777-L780 Closes #366
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-366-vshard-user-experience
branch
from
10db835
to
5912e3d
Compare
DifferentialOrange
deleted the
oleg-jukovec/gh-366-vshard-user-experience
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch adds execution access on a stroage for crud functions to a VShard storage user in the VShard manner [1].
I didn't forget about
Closes #366