feedback: Module popen

[TarantoolBot]

<…>eated with
popen.new() or
popen.shell()
opts (table) – options

|Return:true on success, false on error
Return type:(if success) string with read value, empty string if EOF
(if failure) nil, err|

Possible opts items are:

opts.stdout (boolean, default true, <…>

https://www.tarantool.io/en/doc/2.4/reference/reference_lua/popen/#lua-function.popen_handle.read

Technically there are failures that raise an error. The original documentation request list them first and only then possible return values (success / failure), so there should be no confusion.

Here, however, return values are listed first that may lead to false assumtion that all failures are reported using nil, err. I suggest to add Raise: subsection before Return: and Return type: ones.

What do you think?

[lenkis]

@Totktonada this makes sense to me. Do you agree?

[Totktonada]

I filed it :)