dial: add DialContext function
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekBum
force-pushed
the
DerekBum-no-gh-add-dial-with-context
branch
from
bdadb81
to
be9a218
Compare
DerekBum
force-pushed
the
DerekBum-no-gh-add-dial-with-context
branch
5 times, most recently
from
42ce539
to
db9ed8f
Compare
DerekBum
force-pushed
the
DerekBum-no-gh-add-dial-with-context
branch
from
db9ed8f
to
ae4549a
Compare
DerekBum
force-pushed
the
DerekBum-no-gh-add-dial-with-context
branch
2 times, most recently
from
26d211b
to
a46839f
Compare
oleg-jukovec
reviewed
Oct 2, 2023
|
Please, disable the windows runners (it is not our target platform or we need to fix tests on it). |
DerekBum
force-pushed
the
DerekBum-no-gh-add-dial-with-context
branch
2 times, most recently
from
f881d30
to
b3ae863
Compare
oleg-jukovec
approved these changes
Oct 2, 2023
DerekBum
force-pushed
the
DerekBum-no-gh-add-dial-with-context
branch
from
b3ae863
to
8201b31
Compare
DerekBum
added a commit
that referenced
this pull request
Oct 2, 2023
Disabling of the Windows runner. These tests were flaking. Because we don't support connector on Windows, I considered disabling these tests. Part of #10
DerekBum
added a commit
that referenced
this pull request
Oct 2, 2023
Disabling of the Windows runner. These tests were flaking. Because we don't support connector on Windows, I considered disabling these tests. Part of #10
DerekBum
force-pushed
the
DerekBum-no-gh-add-dial-with-context
branch
from
c1eabdc
to
e88579e
Compare
|
Disabled windows runners (in a separate commit). |
DifferentialOrange
approved these changes
Oct 4, 2023
oleg-jukovec
reviewed
Oct 4, 2023
DerekBum
added a commit
that referenced
this pull request
Oct 4, 2023
Disabling of the Windows runner. These tests were flaking. Because we don't support connector on Windows, I considered disabling these tests. Part of #10
DerekBum
force-pushed
the
DerekBum-no-gh-add-dial-with-context
branch
from
e88579e
to
30e397d
Compare
In order to replace timeouts with contexts in `Connect` instance creation (go-tarantool), I need a `DialContext` function. It accepts context, and cancels, if context is canceled by user. Part of tarantool/go-tarantool#136
Disabling of the Windows runner. These tests were flaking. Because we don't support connector on Windows, I considered disabling these tests. Part of #10
DerekBum
force-pushed
the
DerekBum-no-gh-add-dial-with-context
branch
from
30e397d
to
ac865f3
Compare
oleg-jukovec
added a commit
that referenced
this pull request
Feb 8, 2024
Overview
The first release with a number of fixes. Since `libp2p/openssl`
is not supported any more we need to support our version for usage
in the Golang connector `tarantool/go-tarantool`.
New features
DialContext function (#10).
Bugfixes
Build by Golang 1.13 (#6).
Build with OpenSSL < 1.1.1 (#7).
Build on macOS as a static library (#8).
Build on macOS with Apple M1 (#8).
Random errors in the code caused by an invalid OpenSSL error
handling in LoadPrivateKeyFromPEM,
LoadPrivateKeyFromPEMWithPassword,
LoadPrivateKeyFromDER and LoadPublicKeyFromPEM (#9).
Merged
oleg-jukovec
added a commit
that referenced
this pull request
Feb 8, 2024
Overview
The first release with a number of fixes. Since `libp2p/openssl`
is not supported any more we need to support our version for usage
in the Golang connector `tarantool/go-tarantool`.
See releases of `libp2p/openssl`[1] for previous changes history.
New features
DialContext function (#10).
Bugfixes
Build by Golang 1.13 (#6).
Build with OpenSSL < 1.1.1 (#7).
Build on macOS as a static library (#8).
Build on macOS with Apple M1 (#8).
Random errors in the code caused by an invalid OpenSSL error
handling in LoadPrivateKeyFromPEM,
LoadPrivateKeyFromPEMWithPassword,
LoadPrivateKeyFromDER and LoadPublicKeyFromPEM (#9).
1. https://github.com/libp2p/go-openssl/releases
oleg-jukovec
added a commit
that referenced
this pull request
Feb 8, 2024
Overview
The first release with a number of fixes. Since `libp2p/openssl`
is not supported any more we need to support our version for usage
in the Golang connector `tarantool/go-tarantool`.
See releases of `libp2p/openssl`[1] for previous changes history.
New features
DialContext function (#10).
Bugfixes
Build by Golang 1.13 (#6).
Build with OpenSSL < 1.1.1 (#7).
Build on macOS as a static library (#8).
Build on macOS with Apple M1 (#8).
Random errors in the code caused by an invalid OpenSSL error
handling in LoadPrivateKeyFromPEM,
LoadPrivateKeyFromPEMWithPassword,
LoadPrivateKeyFromDER and LoadPublicKeyFromPEM (#9).
1. https://github.com/libp2p/go-openssl/releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to replace timeouts with contexts in
Connectinstance creation (go-tarantool), I need aDialContextfunction. It accepts context, and cancels, if context is canceled by user.Disabled flaking CI Windows runner. Because we don't support connector on Windows, I considered disabling these tests.
Part of tarantool/go-tarantool#136