Fix static build on macOS #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build tag `openssl_static` does not produce a binary with static linked libcrypto and libssl. The patch fixes it. Related to tarantool/tt#308
oleg-jukovec
force-pushed
the
oleg-jukovec/darwin-build-fix
branch
from
74a1bbd
to
d50a446
Compare
|
According to https://docs.brew.sh/Installation, /usr/local is for Intel binaries/libraries, /opt/homebrew for ARM. |
/usr/local is for Intel binaries/libraries, /opt/homebrew for ARM [1]. 1. https://docs.brew.sh/Installation Related to tarantool/go-tarantool#260
oleg-jukovec
force-pushed
the
oleg-jukovec/darwin-build-fix
branch
from
d50a446
to
58cfcbf
Compare
better0fdead
approved these changes
Mar 6, 2023
AnaNek
approved these changes
Mar 6, 2023
oleg-jukovec
added a commit
that referenced
this pull request
Feb 8, 2024
Overview
The first release with a number of fixes. Since `libp2p/openssl`
is not supported any more we need to support our version for usage
in the Golang connector `tarantool/go-tarantool`.
New features
DialContext function (#10).
Bugfixes
Build by Golang 1.13 (#6).
Build with OpenSSL < 1.1.1 (#7).
Build on macOS as a static library (#8).
Build on macOS with Apple M1 (#8).
Random errors in the code caused by an invalid OpenSSL error
handling in LoadPrivateKeyFromPEM,
LoadPrivateKeyFromPEMWithPassword,
LoadPrivateKeyFromDER and LoadPublicKeyFromPEM (#9).
Merged
oleg-jukovec
added a commit
that referenced
this pull request
Feb 8, 2024
Overview
The first release with a number of fixes. Since `libp2p/openssl`
is not supported any more we need to support our version for usage
in the Golang connector `tarantool/go-tarantool`.
See releases of `libp2p/openssl`[1] for previous changes history.
New features
DialContext function (#10).
Bugfixes
Build by Golang 1.13 (#6).
Build with OpenSSL < 1.1.1 (#7).
Build on macOS as a static library (#8).
Build on macOS with Apple M1 (#8).
Random errors in the code caused by an invalid OpenSSL error
handling in LoadPrivateKeyFromPEM,
LoadPrivateKeyFromPEMWithPassword,
LoadPrivateKeyFromDER and LoadPublicKeyFromPEM (#9).
1. https://github.com/libp2p/go-openssl/releases
oleg-jukovec
added a commit
that referenced
this pull request
Feb 8, 2024
Overview
The first release with a number of fixes. Since `libp2p/openssl`
is not supported any more we need to support our version for usage
in the Golang connector `tarantool/go-tarantool`.
See releases of `libp2p/openssl`[1] for previous changes history.
New features
DialContext function (#10).
Bugfixes
Build by Golang 1.13 (#6).
Build with OpenSSL < 1.1.1 (#7).
Build on macOS as a static library (#8).
Build on macOS with Apple M1 (#8).
Random errors in the code caused by an invalid OpenSSL error
handling in LoadPrivateKeyFromPEM,
LoadPrivateKeyFromPEMWithPassword,
LoadPrivateKeyFromDER and LoadPublicKeyFromPEM (#9).
1. https://github.com/libp2p/go-openssl/releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build tag
openssl_staticdoes not produce a binary with static linked libcrypto and libssl. The patch fixes it.Related to tarantool/tt#308
The patch also fix build on macOS with Apple M1
Related to tarantool/go-tarantool#260
How-to test the static build: