Skip to content

Commit

Permalink
ci: improve golangci-lint output
Browse files Browse the repository at this point in the history
After the patch golangci-lint prints a file and a line number [1].

1. golangci/golangci-lint-action#119

Closes #231
  • Loading branch information
oleg-jukovec committed Dec 27, 2022
1 parent a1f28a6 commit 25973fd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
12 changes: 11 additions & 1 deletion .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ jobs:
- uses: actions/checkout@v2

- name: golangci-lint
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
continue-on-error: true
with:
# The suppression of the rule `errcheck` may be removed after adding
# errors check in all methods calling EncodeXxx inside.
Expand All @@ -47,8 +48,17 @@ jobs:
# The `//nolint` workaround was not the acceptable way of warnings suppression,
# cause those comments get rendered in documentation by godoc.
# See https://github.com/tarantool/go-tarantool/pull/160#discussion_r858608221
#
# The first run is for GitHub Actions error format.
args: -E goimports -D errcheck

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
# The second run is for human-readable error format with a file name
# and a line number.
args: --out-${NO_FUTURE}format colored-line-number -E goimports -D errcheck

codespell:
runs-on: ubuntu-latest
if: |
Expand Down
2 changes: 1 addition & 1 deletion connector.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ type Connector interface {
Select(space, index interface{}, offset, limit, iterator uint32, key interface{}) (resp *Response, err error)
Insert(space interface{}, tuple interface{}) (resp *Response, err error)
Replace(space interface{}, tuple interface{}) (resp *Response, err error)
Delete(space, index interface{}, key interface{}) (resp *Response, err error)
Delete(space, index interface{}, key interface{}) (resp *Response, err error)
Update(space, index interface{}, key, ops interface{}) (resp *Response, err error)
Upsert(space interface{}, tuple, ops interface{}) (resp *Response, err error)
Call(functionName string, args interface{}) (resp *Response, err error)
Expand Down

0 comments on commit 25973fd

Please sign in to comment.