Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify the result of Connection.Do().Get() #311

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

oleg-jukovec
Copy link
Collaborator

We add meaningful error descriptions for a read/write socket errors for and examples:

  • ExampleConnection_Do demonstrates how to process a result.
  • ExampleConnection_Do_failure demonstrates how to process a request failure.

I didn't forget about (remove if it is not applicable):

Related issues:

Closes #129

@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/gh-129-unexpected branch 3 times, most recently from 1172dec to 5a6a79e Compare June 28, 2023 17:02
@oleg-jukovec oleg-jukovec marked this pull request as ready for review June 28, 2023 18:03
We need to add meaningful error descriptions for a read/write socket
errors.

Part of #129
- ExampleConnection_Do demonstrates how to process a result.
- ExampleConnection_Do_failure demonstrates how to process a request
  failure.

Closes #128
@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/gh-129-unexpected branch from 5a6a79e to aa71a64 Compare June 28, 2023 18:06
@oleg-jukovec oleg-jukovec merged commit 7cc61fd into master Jun 29, 2023
22 checks passed
@oleg-jukovec oleg-jukovec deleted the oleg-jukovec/gh-129-unexpected branch June 29, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2: unexpected response on connect tear
3 participants