-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discard http v2 #142
Merged
Merged
Discard http v2 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
force-pushed
the
ligurio/gh-134-discard-v2
branch
25 times, most recently
from
October 27, 2021 08:55
073ce2f
to
0c5a706
Compare
ligurio
force-pushed
the
ligurio/gh-134-discard-v2
branch
4 times, most recently
from
October 27, 2021 09:59
7c53996
to
d1d0198
Compare
True. To be honestly, all commits with tests and Github Actions workflows and luacheck support were added for two reasons:
|
ligurio
force-pushed
the
ligurio/gh-134-discard-v2
branch
2 times, most recently
from
October 28, 2021 11:20
5766906
to
166ffad
Compare
Patch reverts all changes made since commit 'add travis builds for tags' (da1407c). All these changes are related to http v2. Reasons are described in issue #134. No test regressions introduced in comparison to http v1. How to check: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo make make check Part of #134
Run tests in CMake by a separate target ('make check') and not as a CMake test. Part of #134
Patch reimplements commit 'Run luacheck on CI, fix warnings' (b660d8e) added for http v2 and later reverted in scope of issue with discard v2. File http/mime_types.lua contains duplicate items in a table, I don't know what items can be removed so I just ignored a file in a luacheck configuration file. Follows up #95 Part of #134
Method req:cookie() implicitly unescapes cookie values. Commit adds ability to get cookie without unescaping: req:cookie('name', { raw = true }) This change was added as a part of http v2 support in commit 'Added ability to set and get cookie without escaping' (42e3002) and later reverted in scope of ticket with discard v2. Follows up #126 Part of #134
Method resp:setcookie() implicitly escapes cookie values. Commit adds ability to set cookie without any escaping with option 'raw': resp:setcookie('name', 'value', { raw = true })` Also added escaping for cookie path, and changed escaping algorithm according to RFC 6265 "HTTP State Management Mechanism", see [1]. This change was added as a part of http v2 support in commit 'Added ability to set and get cookie without escaping' (42e3002) and later reverted in scope of ticket with discard v2. 1. https://tools.ietf.org/html/rfc6265 Follows up #126 Part of #134
ligurio
force-pushed
the
ligurio/gh-134-discard-v2
branch
from
October 28, 2021 11:21
166ffad
to
0a15a31
Compare
DifferentialOrange
approved these changes
Oct 28, 2021
ylobankov
added a commit
to tarantool/metrics
that referenced
this pull request
Oct 29, 2021
At this moment http dependency in tests is broken since we try to install http 2.1.0 version. But http v2 is gone (tarantool/http#142) and lua rock 2.1.0 is not available anymore. That is the reason of test failures with the following error: http not found for Lua 5.1. Error: No results matching query were found for Lua 5.1. Checking if available for other Lua versions... make: *** [Makefile:10: .rocks] Error 1 Checking for Lua 5.2... Checking for Lua 5.3... Checking for Lua 5.4... Error: Process completed with exit code 2. So this patch switches use of http v2 to v1 that is the recommended version for using.
ylobankov
added a commit
to tarantool/metrics
that referenced
this pull request
Oct 29, 2021
At this moment http dependency in tests is broken since we try to install http 2.1.0 version. But http v2 is gone (tarantool/http#142) and lua rock 2.1.0 is not available anymore. That is the reason for test failures with the following error: http not found for Lua 5.1. Error: No results matching query were found for Lua 5.1. Checking if available for other Lua versions... make: *** [Makefile:10: .rocks] Error 1 Checking for Lua 5.2... Checking for Lua 5.3... Checking for Lua 5.4... Error: Process completed with exit code 2. So this patch switches the use of http v2 to v1 that is the recommended version for using.
ylobankov
added a commit
to tarantool/metrics
that referenced
this pull request
Oct 29, 2021
At this moment http dependency in tests is broken since we are trying to install the `http 2.1.0` lua rock. Now this rock is not available anymore due to tarantool/http#142 and that is the reason for test failures with the following error: http not found for Lua 5.1. Error: No results matching query were found for Lua 5.1. Checking if available for other Lua versions... make: *** [Makefile:10: .rocks] Error 1 Checking for Lua 5.2... Checking for Lua 5.3... Checking for Lua 5.4... Error: Process completed with exit code 2. Now http v2 is available under the `http-v2-legacy` lua rock and this patch switches the use of `http 2.1.0` to `http-v2-legacy 2.1.0`.
yngvar-antonsson
pushed a commit
to tarantool/metrics
that referenced
this pull request
Oct 29, 2021
At this moment http dependency in tests is broken since we are trying to install the `http 2.1.0` lua rock. Now this rock is not available anymore due to tarantool/http#142 and that is the reason for test failures with the following error: http not found for Lua 5.1. Error: No results matching query were found for Lua 5.1. Checking if available for other Lua versions... make: *** [Makefile:10: .rocks] Error 1 Checking for Lua 5.2... Checking for Lua 5.3... Checking for Lua 5.4... Error: Process completed with exit code 2. Now http v2 is available under the `http-v2-legacy` lua rock and this patch switches the use of `http 2.1.0` to `http-v2-legacy 2.1.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134