Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect clock_delta metric #232

Closed
rosik opened this issue Apr 28, 2021 · 0 comments · Fixed by #250
Closed

Collect clock_delta metric #232

rosik opened this issue Apr 28, 2021 · 0 comments · Fixed by #250
Labels
customer feature A new functionality

Comments

@rosik
Copy link
Contributor

rosik commented Apr 28, 2021 •
edited
Loading

Membership has a feature for measuring clock drift. The Cartridge uses it for showing an issue if the diff exceeds a threshold.

But even if the issue isn't shown, the exact value of clock_delta may still be interesting for matching logs of two different instances.

Let's expose this metric by default.

Check out this code.

https://github.com/tarantool/cartridge/blob/cc607f5a6508449608f3953a3f93669e8c8c4ab0/cartridge/issues.lua#L375-L398

But, perhaps, in metrics, min and max values should be separate.

See also:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer feature A new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New tnt_clock_delta metric tarantool/metrics
3 participants
@rosik @sharonovd @yngvar-antonsson