Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dashboard compatible with metrics 0.13.0 #133

Closed
no1seman opened this issue Mar 23, 2022 · 3 comments · Fixed by #141
Closed

Make dashboard compatible with metrics 0.13.0 #133

no1seman opened this issue Mar 23, 2022 · 3 comments · Fixed by #141
Assignees
Labels
customer Customer request dashboard Related to dashboard template part of repo enhancement New feature or request

Comments

@no1seman
Copy link

  • add new metrics
  • fix some metrics that was renamed
@DifferentialOrange
Copy link
Member

DifferentialOrange commented Mar 25, 2022

For new panels, refer to #75, #132, #73. I'll leave this ticket here for the following purpose:

I'll make sure to raise priority of this issue when I'll be free of my current duties.

@DifferentialOrange DifferentialOrange added enhancement New feature or request dashboard Related to dashboard template part of repo customer Customer request teamE labels Mar 25, 2022
@opomuc
Copy link
Contributor

opomuc commented Mar 30, 2022

This is my list of what new has happened in metrics module:

Also we need a complete list of current metrics and it's crossreference with panels. If some useful metrics are still not represented on panels (like luajit) maybe we should add the as well

@DifferentialOrange
Copy link
Member

Old lost&found metrics: #137

List of new metrics not covered by other (resolved by now or closed as duplicates) tickets:

  • tnt_net_requests_in_progress_total
  • tnt_net_requests_in_progress_current
  • tnt_net_requests_in_stream_queue_total
  • tnt_net_requests_in_stream_queue_current
  • tnt_clock_delta
  • tnt_replication_status
  • tnt_read_only
  • tnt_vinyl_regulator_blocked_writers

They will be added with PR linked to this issue, together with new Telegraph tags and renaming process (after ensuring it is ok to use renamed metrics and no one will be troubled by it).

By closing #137 and #133 with PRs the dashboard will support all useful metrics from 0.13.0: see https://github.com/tarantool/grafana-dashboard/wiki/Metrics-support (except for tnt_info_uptime for InfluxDB dashboard, see #39).

DifferentialOrange added a commit that referenced this issue May 5, 2022
Add a panel for tnt_clock_delta panel to cluster overview section.
Add corresponding "delta" label_pairs to Telegraf.

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
tnt_replication_status was introduced in metrics 0.13.0. This patch adds
replication status timeseries panel to cluster overview section and
corresponding "stream" label pairs to Telegraf.

Timeseries is a base panel since Grafana 8.0. It is possible to set
value mapping in a timeseries panel, which is convenient for replication
status display. There is no way to make a 8.x timeseries panel with
grafana/grafonnet-lib tools for now (7.x subfolder graph
is incompatible), so this patch also introduces a rough draft of a
timeseries panel template.

Grafana requirement was bumped to 8.0.0.

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
DifferentialOrange added a commit that referenced this issue May 5, 2022
Add master/slave status panel to a cluster overview section.
tnt_read_only metric was introduced in 0.11.0.

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
Add vinyl regulator blocked writers panel to a vinyl section.
tnt_vinyl_regulator_blocked_writers metric was introduced in 0.13.0.

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
Add panels for net requests in progress/in stream queue to "Tarantool
network activity" section. Deprecate existing net requests panels
since they are superseded by new ones. (Since new ones are supported in
Tarantool 2.10.0-beta2 or newer, do not remove them yet.) Metrics
were introduced in metrics 0.13.0:
- tnt_net_requests_in_progress_total
- tnt_net_requests_in_progress_current
- tnt_net_requests_in_stream_queue_total
- tnt_net_requests_in_stream_queue_current

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
In metrics 0.13.0, the following metrics were deprecated:
- tnt_replication_*_lag
- tnt_fiber_count
- tnt_space_count
- tnt_vinyl_scheduler_dump_count

Instead of them, new metrics were introduced:
- tnt_replication_lag
- tnt_fiber_amount
- tnt_vinyl_tuples
- tnt_vinyl_scheduler_dump_total

This patch replaces deprecated metrics with their aliases.

Closes #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
Add panels for net requests in progress/in stream queue to "Tarantool
network activity" section. Deprecate existing net requests panels
since they are superseded by new ones. (Since new ones are supported in
Tarantool 2.10.0-beta2 or newer, do not remove them yet.) Metrics
were introduced in metrics 0.13.0:
- tnt_net_requests_in_progress_total
- tnt_net_requests_in_progress_current
- tnt_net_requests_in_stream_queue_total
- tnt_net_requests_in_stream_queue_current

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
In metrics 0.13.0, the following metrics were deprecated:
- tnt_replication_*_lag
- tnt_fiber_count
- tnt_space_count
- tnt_vinyl_scheduler_dump_count

Instead of them, new metrics were introduced:
- tnt_replication_lag
- tnt_fiber_amount
- tnt_vinyl_tuples
- tnt_vinyl_scheduler_dump_total

This patch replaces deprecated metrics with their aliases.

Closes #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
DifferentialOrange added a commit that referenced this issue May 5, 2022
Add a panel for tnt_clock_delta panel to cluster overview section.
Add corresponding "delta" label_pairs to Telegraf.

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
tnt_replication_status was introduced in metrics 0.13.0. This patch adds
replication status timeseries panel to cluster overview section and
corresponding "stream" label pairs to Telegraf.

Timeseries is a base panel since Grafana 8.0. It is possible to set
value mapping in a timeseries panel, which is convenient for replication
status display. There is no way to make a 8.x timeseries panel with
grafana/grafonnet-lib tools for now (7.x subfolder graph
is incompatible), so this patch also introduces a rough draft of a
timeseries panel template.

Grafana requirement was bumped to 8.0.0.

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
DifferentialOrange added a commit that referenced this issue May 5, 2022
Add master/slave status panel to a cluster overview section.
tnt_read_only metric was introduced in 0.11.0.

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
Add vinyl regulator blocked writers panel to a vinyl section.
tnt_vinyl_regulator_blocked_writers metric was introduced in 0.13.0.

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
Add panels for net requests in progress/in stream queue to "Tarantool
network activity" section. Deprecate existing net requests panels
since they are superseded by new ones. (Since new ones are supported in
Tarantool 2.10.0-beta2 or newer, do not remove them yet.) Metrics
were introduced in metrics 0.13.0:
- tnt_net_requests_in_progress_total
- tnt_net_requests_in_progress_current
- tnt_net_requests_in_stream_queue_total
- tnt_net_requests_in_stream_queue_current

Part of #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
In metrics 0.13.0, the following metrics were deprecated:
- tnt_replication_*_lag
- tnt_fiber_count
- tnt_space_count
- tnt_vinyl_scheduler_dump_count

Instead of them, new metrics were introduced:
- tnt_replication_lag
- tnt_fiber_amount
- tnt_vinyl_tuples
- tnt_vinyl_scheduler_dump_total

This patch replaces deprecated metrics with their aliases.

Closes #133
DifferentialOrange added a commit that referenced this issue May 5, 2022
DifferentialOrange added a commit that referenced this issue May 6, 2022
DifferentialOrange added a commit that referenced this issue May 6, 2022
DifferentialOrange added a commit that referenced this issue May 6, 2022
DifferentialOrange added a commit that referenced this issue May 6, 2022
DifferentialOrange added a commit that referenced this issue Jun 8, 2022
Change replication status "slave" labels to "replica" to be consistent
with documentation.

Follows up #133
DifferentialOrange added a commit that referenced this issue Jun 8, 2022
Change replication status "slave" labels to "replica" to be consistent
with documentation.

Follows up #133
DifferentialOrange added a commit that referenced this issue Aug 5, 2022
Replication lag alert example uses deprecated tnt_replication_*_lag
metric. This patch replaces it with up-to-date tnt_replication_lag{id=*}
metric.

Follows up #133
DifferentialOrange added a commit that referenced this issue Aug 16, 2022
Replication lag alert example uses deprecated tnt_replication_*_lag
metric. This patch replaces it with up-to-date tnt_replication_lag{id=*}
metric.

Follows up #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer Customer request dashboard Related to dashboard template part of repo enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants