Skip to content

Commit

Permalink
build: disable backtrace feature on AArch64 Linux
Browse files Browse the repository at this point in the history
There are sporadic segfaults in libunwind during backtrace_collect().
Reproducible with the latest version, and there are open issues with
similar stacks:

libunwind/libunwind#150
libunwind/libunwind#260
libunwind/libunwind#473

Let's disable ENABLE_BACKTRACE for AArch64 Linux until these issues are
resolved in libunwind.

Closes #8572
Part of #8791

NO_DOC=bugfix

(cherry picked from commit 418e749)
  • Loading branch information
Gumix authored and locker committed Jun 22, 2023
1 parent ecd4af1 commit e999c31
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## bugfix/core

* Disabled the backtrace collection feature on the AArch64 Linux platform
(gh-8572).
5 changes: 3 additions & 2 deletions cmake/compiler.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,9 @@ check_c_source_compiles(
set(ENABLE_BACKTRACE_DEFAULT OFF)
# Disabled backtraces support on FreeBSD by default, because of
# gh-4278.
if(NOT TARGET_OS_FREEBSD AND HAVE_FORCE_ALIGN_ARG_POINTER_ATTR
AND HAVE_CFI_ASM)
# Disabled backtraces support on AArch64 Linux by default, because of gh-8791.
if(NOT TARGET_OS_FREEBSD AND HAVE_FORCE_ALIGN_ARG_POINTER_ATTR AND HAVE_CFI_ASM
AND NOT (TARGET_OS_LINUX AND CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64"))
set(ENABLE_BACKTRACE_DEFAULT ON)
endif()

Expand Down
3 changes: 0 additions & 3 deletions test/app-luatest/gh_8445_crash_during_crash_report_test.lua
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ local t = require('luatest')
local g = t.group('gh-8445')

g.before_all(function(cg)
-- TODO(gh-8572)
t.skip_if(jit.arch == 'arm64' and jit.os == 'Linux',
'Disabled on AArch64 Linux due to #8572')
local server = require('luatest.server')
cg.server = server:new({alias = 'gh-8445'})
end)
Expand Down

0 comments on commit e999c31

Please sign in to comment.