Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hardcoded IP ports in tests #1227

Closed
anatol opened this issue Dec 23, 2015 · 3 comments
Closed

Avoid hardcoded IP ports in tests #1227

anatol opened this issue Dec 23, 2015 · 3 comments
Assignees
@GeorgyKirichenko
Milestone
1.6.9

Comments

@anatol
Copy link
Contributor

anatol commented Dec 23, 2015

There are some tests that use a specific port. e.g.

tarantool/test/box/socket.test.lua

Line 72 in 8e3534c

s:bind('127.0.0.1', 3457)

tarantool/test/replication/prune.test.lua

Line 6 in 8e3534c

test_run = env.new('127.0.0.1', 8080)

These ports might be already used by some other process. Especially it is true for port 8080 that is used as a default by a number of tools. And it will cause tarantool test failure.

Ideally if available port in the test chosen dynamically by passing 0 to bind() syscall.
@rtsisyk rtsisyk added this to the 1.6.8 milestone Dec 23, 2015
@rtsisyk
Copy link
Contributor

rtsisyk commented Dec 23, 2015

+1
test-run definitely must be fixed to use a random port instead of 8080.

@rtsisyk rtsisyk assigned GeorgyKirichenko and unassigned Sulverus Jan 18, 2016
rtsisyk pushed a commit to tarantool/test-run that referenced this issue Jan 29, 2016
@GeorgyKirichenko @rtsisyk
Avoid hardcoded inspector IP in tests.
052eac2 
tarantool/tarantool#1227
rtsisyk added a commit that referenced this issue Jan 29, 2016
@rtsisyk
Update test-run to fix #1227
42e4b29
@rtsisyk
Copy link
Contributor

rtsisyk commented Jan 29, 2016

test-run fixed (port 8080), prune.test.lua fixed.

@GeorgyKirichenko please try to fix socket.test.lua.
This test fails too often on Travis and locally.

@rtsisyk
Copy link
Contributor

rtsisyk commented Feb 9, 2016

socket.test also should not try to connect to remote servers

@rtsisyk rtsisyk modified the milestones: 1.6.9, 1.6.8 Feb 19, 2016
GeorgyKirichenko added a commit that referenced this issue Apr 14, 2016
@GeorgyKirichenko
Avoid hardcoded tcp port for socket test. Fixed #1227
19462bc
sergw pushed a commit that referenced this issue Sep 18, 2018
test: unskip forgotten tests
b3affb6 
These tickets already closed: #1227, #1322
And http_client test works ok on Travis
avtikhon added a commit that referenced this issue Mar 5, 2020
@avtikhon
Return to testing some tests after fixed issues
0cf1145 
After issues #1227 and #1322 the tests were returned
into the testing.
avtikhon added a commit that referenced this issue Mar 5, 2020
@avtikhon
Return to testing some tests after fixed issues
4dad788 
After issues #1227 and #1322 the tests were returned
into the testing.
avtikhon added a commit that referenced this issue Mar 10, 2020
@avtikhon
Return to testing some tests after fixed issues
d24bee6 
After issues #1227 and #1322 the tests were returned
into the testing.
avtikhon added a commit that referenced this issue Mar 11, 2020
@avtikhon
test: add more tests to packaging testing
c16fc02 
Changed number of tests to packaging testing jobs from
suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",
to all suites except 'replication/' suite which has special
issue for it's enabling:
  #4798
Also added testing to the all available packing jobs except
'CentOS 6'.

Removed test-run option that run testing inline to be
able to run it in parallel. Also changed 'test-run' to
'make test-force' command.

After issues #1227 and #1322 the tests were returned
into the testing.

Closes #4599
avtikhon added a commit that referenced this issue Mar 11, 2020
@avtikhon
test: add more tests to packaging testing
6a7ab0f 
Changed number of tests to packaging testing jobs from
suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",
to all suites except 'replication/' suite which has special
issue for it's enabling:
  #4798
Also added testing to the all available packing jobs except
'CentOS 6'.

Removed test-run option that run testing inline to be
able to run it in parallel. Also changed 'test-run' to
'make test-force' command.

After issues #1227 and #1322 the tests were returned
into the testing.

Closes #4599
avtikhon added a commit that referenced this issue Mar 12, 2020
@avtikhon
test: add more tests to packaging testing
a4916dc 
Changed number of tests to packaging testing jobs from
suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",
to all suites except 'replication/' suite which has special
issue for it's enabling:
  #4798
Also added testing to the all available packing jobs except
'CentOS 6'.

Removed test-run option that run testing inline to be
able to run it in parallel. Also changed 'test-run' to
'make test-force' command.

After issues #1227 and #1322 the tests were returned
into the testing.

Closes #4599
avtikhon added a commit that referenced this issue Mar 31, 2020
@avtikhon
test: add more tests to packaging testing
458337e 
Changed number of tests to packaging testing jobs from
suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",
to all suites except 'replication/' suite which has special
issue for it's enabling:
  #4798
Also added testing to the all available packing jobs except
'CentOS 6'.

Removed test-run option that run testing inline to be
able to run it in parallel. Also changed 'test-run' to
'make test-force' command.

After issues #1227 and #1322 the tests were returned
into the testing.

Closes #4599
avtikhon added a commit that referenced this issue Apr 23, 2020
@avtikhon
test: add more tests to packaging testing
191ecf6 
Changed number of tests to packaging testing jobs from
suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",
to all suites except 'replication/' suite which has special
issue for it's enabling:
  #4798
Also added testing to the all available packing jobs except
'CentOS 6'.

Removed test-run option that run testing inline to be
able to run it in parallel. Also changed 'test-run' to
'make test-force' command.

After issues #1227 and #1322 the tests were returned
into the testing.

Closes #4599
avtikhon added a commit that referenced this issue May 7, 2020
@avtikhon
test: add more tests to packaging testing
279b62e 
Changed number of tests to packaging testing jobs from
suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",
to all suites except 'replication/' suite which has special
issue for it's enabling:
  #4798
Also added testing to the all available packing jobs except
'CentOS 6'.

Removed test-run option that run testing inline to be
able to run it in parallel. Also changed 'test-run' to
'make test-force' command.

After issues #1227 and #1322 the tests were returned
into the testing.

Closes #4599
avtikhon added a commit that referenced this issue May 8, 2020
@avtikhon
test: add more tests to packaging testing
687a0c5 
Changed number of tests to packaging testing jobs from
suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",
to all suites except 'replication/' suite which has special
issue for it's enabling:
  #4798
Also added testing to the all available packing jobs except
'CentOS 6'.

Removed test-run option that run testing inline to be
able to run it in parallel. Also changed 'test-run' to
'make test-force' command.

After issues #1227 and #1322 the tests were returned
into the testing.

Closes #4599
avtikhon added a commit that referenced this issue May 10, 2020
@avtikhon
test: return tests to packaging testing
efc512d 
Found that issues #1227 and #1322 were closed, returned
the tests blocked by it into the testing.

Closes #4599
avtikhon added a commit that referenced this issue May 12, 2020
@avtikhon
test: return tests to packaging testing
07798d8 
Found that issues #1227 and #1322 were closed, returned
the tests blocked by it into the testing.

Part of #4599
avtikhon added a commit that referenced this issue May 12, 2020
@avtikhon
test: return tests to packaging testing
bbe0a76 
Found that issues #1227 and #1322 were closed, returned
the tests blocked by it into the testing.

Part of #4599
avtikhon added a commit that referenced this issue May 19, 2020
@avtikhon
test: return tests to packaging testing
1acc8c4 
Found that issues #1227 and #1322 were closed, returned
the tests blocked by it into the testing.

Part of #4599
avtikhon added a commit that referenced this issue May 20, 2020
@avtikhon
test: return tests to packaging testing
7f3476e 
Found that issues #1227 and #1322 were closed, returned
the tests blocked by it into the testing.

Part of #4599
kyukhin pushed a commit that referenced this issue May 20, 2020
@avtikhon @kyukhin
test: return tests to packaging testing
f588066 
Found that issues #1227 and #1322 were closed, returned
the tests blocked by it into the testing.

Part of #4599
kyukhin pushed a commit that referenced this issue May 20, 2020
@avtikhon @kyukhin
test: return tests to packaging testing
3080609 
Found that issues #1227 and #1322 were closed, returned
the tests blocked by it into the testing.

Part of #4599

(cherry picked from commit f588066)
kyukhin pushed a commit that referenced this issue May 20, 2020
@avtikhon @kyukhin
test: return tests to packaging testing
38700ac 
Found that issues #1227 and #1322 were closed, returned
the tests blocked by it into the testing.

Part of #4599

(cherry picked from commit f588066)
kyukhin pushed a commit that referenced this issue May 20, 2020
@avtikhon @kyukhin
test: return tests to packaging testing
26beb52 
Found that issues #1227 and #1322 were closed, returned
the tests blocked by it into the testing.

Part of #4599

(cherry picked from commit f588066)
avtikhon pushed a commit that referenced this issue Jun 22, 2020
@sergepetrenko @avtikhon
build: enable bundled libyaml for all systems.
815ba93 
After we fixed bundled libyaml to correctly print 4-byte Unicode
characters, it is no longer compatible with the upstream version, so
enable building with bundled libyaml for every platform.
This way the tests will pass.

Follow-up #4090

(cherry picked from commit 47b91e9)

After the app/digest.test.lua and app/socket.test.lua where unblocked
by the commit:

  f588066
  commit f588066
  Author: Alexander V. Tikhonov <avtikhon@tarantool.org>
  Date:   Sun May 10 09:28:15 2020 +0300

    test: return tests to packaging testing

    Found that issues #1227 and #1322 were closed, returned
    the tests blocked by it into the testing.

    Part of #4599

THe following issue appeared in the both tests:

 [032] --- app/digest.result  Thu May 21 03:21:02 2020
 [032] +++ app/digest.reject  Thu May 21 03:26:47 2020
 [032] @@ -333,7 +333,7 @@
 [032]
 [032]    YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh
 [032]
 [032] -  '
 [032] +'
 [032]  ...
 [032]  digest.base64_decode(b) == s
 [032]  ---
 [032]

Found that the issue was already fixed in the main trunk of Tarantool
2.x version where bundled libyaml was used. To fix the tests in 1.10
version decided to use bundled libyaml too.
avtikhon pushed a commit that referenced this issue Jun 23, 2020
@sergepetrenko @avtikhon
build: enable bundled libyaml for all systems.
d3c979b 
After we fixed bundled libyaml to correctly print 4-byte Unicode
characters, it is no longer compatible with the upstream version, so
enable building with bundled libyaml for every platform.
This way the tests will pass.

Follow-up #4090

(cherry picked from commit 47b91e9)

After the app/digest.test.lua and app/socket.test.lua where unblocked
by the commit:

  f588066
  commit f588066
  Author: Alexander V. Tikhonov <avtikhon@tarantool.org>
  Date:   Sun May 10 09:28:15 2020 +0300

    test: return tests to packaging testing

    Found that issues #1227 and #1322 were closed, returned
    the tests blocked by it into the testing.

    Part of #4599

THe following issue appeared in the both tests:

 [032] --- app/digest.result  Thu May 21 03:21:02 2020
 [032] +++ app/digest.reject  Thu May 21 03:26:47 2020
 [032] @@ -333,7 +333,7 @@
 [032]
 [032]    YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh
 [032]
 [032] -  '
 [032] +'
 [032]  ...
 [032]  digest.base64_decode(b) == s
 [032]  ---
 [032]

Found that the issue was already fixed in the main trunk of Tarantool
2.x version where bundled libyaml was used. To fix the tests in 1.10
version decided to use bundled libyaml too.
kyukhin pushed a commit that referenced this issue Jun 26, 2020
@sergepetrenko @kyukhin
build: enable bundled libyaml for all systems.
c7ff3c9 
After we fixed bundled libyaml to correctly print 4-byte Unicode
characters, it is no longer compatible with the upstream version, so
enable building with bundled libyaml for every platform.
This way the tests will pass.

Follow-up #4090

(cherry picked from commit 47b91e9)

After the app/digest.test.lua and app/socket.test.lua where unblocked
by the commit:

  f588066
  commit f588066
  Author: Alexander V. Tikhonov <avtikhon@tarantool.org>
  Date:   Sun May 10 09:28:15 2020 +0300

    test: return tests to packaging testing

    Found that issues #1227 and #1322 were closed, returned
    the tests blocked by it into the testing.

    Part of #4599

THe following issue appeared in the both tests:

 [032] --- app/digest.result  Thu May 21 03:21:02 2020
 [032] +++ app/digest.reject  Thu May 21 03:26:47 2020
 [032] @@ -333,7 +333,7 @@
 [032]
 [032]    YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh
 [032]
 [032] -  '
 [032] +'
 [032]  ...
 [032]  digest.base64_decode(b) == s
 [032]  ---
 [032]

Found that the issue was already fixed in the main trunk of Tarantool
2.x version where bundled libyaml was used. To fix the tests in 1.10
version decided to use bundled libyaml too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgyKirichenko GeorgyKirichenko

Labels
None yet
Projects
None yet
Milestone
1.6.9
Development

No branches or pull requests
4 participants
@anatol @Sulverus @rtsisyk @GeorgyKirichenko