New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize tuple_tostring and tuple to yaml encoding #128
Comments
Needed for @zlobspb |
ilmarkov
added a commit
that referenced
this issue
Jun 16, 2017
Change implementation of tuple_to_string Old variant coverted tuple to lua table, then encoded to yaml New variant encodes tuple to yaml. Add new function to API box_tuple_to_string Relates #128 Results of benchmarking with: old: 1m27.555s new: 0m50.830s Acceleration 43%
ilmarkov
added a commit
that referenced
this issue
Jun 19, 2017
Old variant converted tuple to lua table, then encoded to yaml New variant encodes tuple to yaml. Relates #128 Results of benchmarking with: old: 1m27.555s new: 0m48.738s Acceleration 44%
rtsisyk
added a commit
that referenced
this issue
Jun 20, 2017
* Inline IS_PRINTABLE macros into check_utf8() * Rename yaml_check_utf8() to utf8_check() * Get rid of libyaml-private dependency for lua-yaml Needed for #128
rtsisyk
pushed a commit
that referenced
this issue
Jun 20, 2017
Old variant converted tuple to Lua table and then encoded to yaml New variant encodes tuple to yaml directly. Results of benchmarking with: old: 1m27.555s new: 0m48.738s Acceleration 44% Closes #128
rtsisyk
added a commit
that referenced
this issue
Jun 20, 2017
* Fix handling of encoded data * Remove \n added by libyaml * Add a test case Follow up #128
1.7.4-177-g0a7ca4b2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current implementation unpacks entire tuple to Lua and then calls yaml.encode on it.
It was the simplest solution I've found for support MsgPack tuples.
Please use libyaml directly and "remove the PHP" (c) Kostja from the code!
See also #30
The text was updated successfully, but these errors were encountered: