Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable changing field.is_nullable from false to true on a non empty space #2973

Closed
nekufa opened this issue Nov 30, 2017 · 1 comment
Closed

Enable changing field.is_nullable from false to true on a non empty space #2973

nekufa opened this issue Nov 30, 2017 · 1 comment
Assignees
@Gerold103
Labels
app feature A new functionality
Milestone
1.9.0

Comments

@nekufa
Copy link

nekufa commented Nov 30, 2017

Now we can't update format and allow a field to be nullable.
This operation does not require special check for space tuples.
The only check should be - there are no non-nullable indexes that uses the field.
@nekufa nekufa changed the title Enable field.is_nullable on a not empty space Enable field.is_nullable on a non empty space Nov 30, 2017
@kostja kostja changed the title Enable field.is_nullable on a non empty space Enable changing field.is_nullable from false to true on a non empty space Jan 9, 2018
@kostja kostja added this to the 1.7.7 milestone Jan 9, 2018
@Gerold103 Gerold103 added the feature A new functionality label Jan 9, 2018
@kostja kostja modified the milestones: 1.7.7, 1.8.7 Jan 22, 2018
@nekufa
Copy link
Author

nekufa commented Jan 26, 2018

workaround is to reinitialize format with: space:format({}) and then space:format(newFormat)

@kostja kostja modified the milestones: 2.1.2, 1.9.0 Feb 11, 2018
Gerold103 added a commit that referenced this issue Feb 13, 2018
@Gerold103
test: ensure is_nullable can be enabled in non-empty space format
4393c41 
Closes #2973
@Gerold103 Gerold103 modified the milestones: 1.10.0, 1.9.0 Feb 14, 2018
kostja pushed a commit that referenced this issue Feb 20, 2018
@Gerold103 @kostja
test: ensure is_nullable can be enabled in non-empty space format
06aa026 
Closes #2973
@kostja kostja closed this as completed Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gerold103 Gerold103

Labels
app feature A new functionality
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
3 participants
@nekufa @kostja @Gerold103