sql: SQLite backend removal follow-up: cleanups #3119

kyukhin · 2018-02-05T16:02:39Z

Refactor struct CursorPayload, only two fields are used in box/sql.c: key and nkey. Maybe even remove whole struct
Refactor struct Schema: only 3 fields are actually used fkey, tableandtrigger`
Remove code under OMIT_DEPRECATED ifndef
Remove struct Db, the only field used in this struct is Schema
Remove code under OMIT_AUTHORIZED ifndef
Remove journal_mode, file memjournal.c and code under OMIT_WAL infdef
Remove opcode OP_Transaction: it was superseded by Tarantool's specific OP_TTransaction
Remove from types of 4-th argument in VDBE type P4_TABLE: no tables anymore
Remove code under OMIT_AUTOINCREMENT ifndef

The text was updated successfully, but these errors were encountered:

Remove all code under OMIT_AUTOINCREMENT define and refactor the rest For #3119

Remove P4_Table type from 4th VDBE argument, because there are no tables anymore For #3119

Remove code under ifndef OMIT_DEPRECATED For #3119

Remove struct Db for backend removal follow-up. For #3119

Refactor struct Schema - remove all unnecessary fields, save only actually used fields like tblHash, trigHash, fkeyHash. For #3119

Refactor CursorPayload structure. Remove all the fields except pKey and nKey, because only them are actually used in sql.c For #3119

Remove journal_mode, remove memjournal.c and refactor code. For #3119

Remove every code used for sqlite backend authorization, because it is completely unnecessary now. Also remove OP_Transaction, modify OP_TTransaction. For #3119

Remove all code under OMIT_AUTOINCREMENT define and refactor the rest For #3119

Remove P4_Table type from 4th VDBE argument, because there are no tables anymore For #3119

Remove code under ifndef OMIT_DEPRECATED For #3119

Remove struct Db for backend removal follow-up. For #3119

Refactor struct Schema - remove all unnecessary fields, save only actually used fields like tblHash, trigHash, fkeyHash. For #3119

Remove journal_mode, remove memjournal.c and refactor code. For #3119

Remove every code used for sqlite backend authorization, because it is completely unnecessary now. Also remove OP_Transaction, modify OP_TTransaction, regenerate opcodes. For #3119

Delete CursorPayload structure and delegate all responsibility to BtCursor structure, because it already has all necessary fields for that. For #3119

Refactor struct Schema - remove all unnecessary fields, save only actually used fields like tblHash, trigHash, fkeyHash, schema_cookie. For #3119

Remove journal_mode, remove memjournal.c and refactor code. For #3119

Delete CursorPayload structure and delegate all responsibility to BtCursor structure, because it already has all necessary fields for that. For #3119

Remove every code used for sqlite backend authorization, because it is completely unnecessary now. Also remove OP_Transaction, modify OP_TTransaction, regenerate opcodes. For #3119

Merge OP_Transaction and OP_TTransaction into single opcode. Add additional arguments for OP_TTransaction opcode which will determine whether the Tarantool transaction will be started or not. For #3119

Remove all sqlite code related to SQLite embedded authorization. It is completely unnecessary right now, because in the near future authorization will be handled by Tarantool grants. For #3119

Remove all code under OMIT_AUTOINCREMENT define and refactor the rest For #3119

Remove P4_Table type from 4th VDBE argument, because there are no tables anymore For #3119

Remove code under ifndef OMIT_DEPRECATED For #3119

Remove struct Db for backend removal follow-up. For #3119

Refactor struct Schema - remove all unnecessary fields, save only actually used fields like tblHash, trigHash, fkeyHash, schema_cookie. For #3119

Remove code under ifndef OMIT_DEPRECATED. For #3119

Struct Db contained only one necessary field - struct Schema, which means that it has to be removed in order to make code more clear. And in this patch it was removed. For #3119

Refactor struct Schema - remove all unnecessary fields, save only actually used fields like tblHash, trigHash, fkeyHash, schema_cookie. For #3119

SQL journal is a completely unnecessary element in our code base, it needs to be removed with journal_mode. In this patch it was removed along with refactoring other related code - like VDBE sorter, which may open temp files or SQL pragmas. For #3119

Remove all sqlite code related to SQLite embedded authorization. It is completely unnecessary right now, because in the near future authorization will be handled by Tarantool grants. For #3119

- Delete CursorPayload structure and delegate all responsibility to BtCursor structure, because it already has all necessary fields for that. - Refactor tarantoolSqlite3Insert, tarantoolSqlite3Replace, tarantoolSqlite3EphemeralInsert, remove second argument from that. For #3119

This commit is a part of work which is necessary for successful removal of OP_Transaction. During that opcode execution it doesn't do any meaningful work, however it presence was necessary, because without that opcode VDBE flags like 'readOnly', 'bIsReader' would be assigned incorrectly. Also unnecessary OP_Destroy opcode was removed. This flags are unnecessary for us, so in this patch they were removed (and everything related to them). For #3119

OP_Transaction in its current state was completely unnecessary. In this patch it was removed, all related code was refactored, opcodes set was regenerated. For #3119

Refactor all code under OMIT_AUTOINCREMENT define. For #3119

Remove P4_Table type from 4th VDBE argument, because there are no tables anymore. For #3119