Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce multi directional iterators #3309

Open
kyukhin opened this issue Apr 3, 2018 · 8 comments
Open

Introduce multi directional iterators #3309

kyukhin opened this issue Apr 3, 2018 · 8 comments
Labels
feature A new functionality
Milestone
wishlist

Comments

@kyukhin
Copy link
Contributor

kyukhin commented Apr 3, 2018

To process SQL queries like this:

SELECT * FROM t1 ORDER BY a DESC, b ASC

Multi directional iterators are needed: we need to be able to specify ASC/DESC
order for each field.
@kyukhin kyukhin added the feature A new functionality label Apr 3, 2018
@kyukhin kyukhin added this to the 2.1.0 milestone Apr 3, 2018
@Korablev77
Copy link
Contributor

Related: #3016 #3243

@kyukhin kyukhin modified the milestones: 2.1.0, 2.1.1 Jul 10, 2018
@Gerold103 Gerold103 mentioned this issue Oct 12, 2018
Open
@kyukhin kyukhin added the prio1 label Nov 12, 2018
@kostja kostja added bug Something isn't working and removed feature A new functionality labels Nov 19, 2018
@Korablev77 Korablev77 mentioned this issue Mar 11, 2019
Closed
@kyukhin kyukhin added feature A new functionality and removed prio1 bug Something isn't working labels Mar 11, 2019
@kyukhin kyukhin modified the milestones: 2.1.2, 2.2.0 Mar 11, 2019
SudoBobo added a commit that referenced this issue Mar 11, 2019
@SudoBobo
sql: forbid different sorting orders in ORDER BY
c006f2d 
Without multi-directional iterators (to be introduced in #3309)
in most cases (except those when internal VDBE merge sorter is
used) ORDER BY with different specified ordered leads to wrong
result. So for now (till #3309 is resolved) different sort
orders are forbidden.

Close #4038

@TarantoolBot document
Title: different sorting orders in ORDER BY are forbidden now
The error will be raised if different sorting orders are
encountered.
SudoBobo added a commit that referenced this issue Mar 11, 2019
@SudoBobo
sql: forbid different sorting orders in ORDER BY
c9f6f80 
Without multi-directional iterators (to be introduced in #3309)
in most cases (except those when internal VDBE merge sorter is
used) ORDER BY with different specified ordered leads to wrong
result. So for now (till #3309 is resolved) different sort
orders are forbidden.

Close #4038

@TarantoolBot document
Title: different sorting orders in ORDER BY are forbidden now
The error will be raised if different sorting orders are
encountered.
SudoBobo added a commit that referenced this issue Mar 15, 2019
@SudoBobo
sql: forbid diff. sorting orders in ORDER BY + LIMIT
acdbc0c 
Without multi-directional iterators (to be introduced in #3309)
ORDER BY + LIMIT with different specified ordered leads to wrong
result. So for now (till #3309 is resolved) different sort
orders are forbidden in ORDER BY + LIMIT.

Close #4038

@TarantoolBot document
Title: different sorting orders in ORDER BY are forbidden now
The error will be raised if different sorting orders are
encountered.
@SudoBobo
Copy link
Contributor

As a temporary solution, we have banned different sorting orders in ORDER BY + LIMIT (#4038). Here are the tests which should be uncommented when the problem with ORDER BY + LIMIT would be solved:
test/sql-tap/orderby6.test.lua 1.21.* , 1.4.2, 1.4.3

SudoBobo added a commit that referenced this issue Mar 15, 2019
@SudoBobo
sql: forbid diff. sorting orders in ORDER BY + LIMIT
9328f9d 
Without multi-directional iterators (to be introduced in #3309)
ORDER BY + LIMIT with different specified ordered leads to wrong
result. So for now (till #3309 is resolved) different sort
orders are forbidden in ORDER BY + LIMIT.

Close #4038

@TarantoolBot document
Title: different sorting orders in ORDER BY are forbidden now
The error will be raised if different sorting orders are
encountered.
SudoBobo added a commit that referenced this issue Mar 15, 2019
@SudoBobo
sql: forbid diff. sorting orders in ORDER BY + LIMIT
8314c75 
Without multi-directional iterators (to be introduced in #3309)
ORDER BY + LIMIT with different specified ordered leads to wrong
result. So for now (till #3309 is resolved) different sort
orders are forbidden in ORDER BY + LIMIT.

Close #4038

@TarantoolBot document
Title: different sorting orders in ORDER BY are forbidden now
The error will be raised if different sorting orders are
encountered.
SudoBobo added a commit that referenced this issue Mar 15, 2019
@SudoBobo
sql: forbid diff. sorting orders in ORDER BY + LIMIT
12d9884 
Without multi-directional iterators (to be introduced in #3309)
ORDER BY + LIMIT with different specified ordered leads to wrong
result. So for now (till #3309 is resolved) different sort
orders are forbidden in ORDER BY + LIMIT.

Close #4038

@TarantoolBot document
Title: different sorting orders in ORDER BY are forbidden now
The error will be raised if different sorting orders are
encountered.
SudoBobo added a commit that referenced this issue Mar 18, 2019
@SudoBobo
sql: forbid diff. sorting orders in ORDER BY + LIMIT
9f3eb10 
Without multi-directional iterators (to be introduced in #3309)
ORDER BY + LIMIT with different specified ordered leads to wrong
result. So for now (till #3309 is resolved) different sort
orders are forbidden in ORDER BY + LIMIT.

Close #4038

@TarantoolBot document
Title: different sorting orders in ORDER BY are forbidden now
The error will be raised if different sorting orders are
encountered.
kyukhin pushed a commit that referenced this issue Mar 19, 2019
@SudoBobo @kyukhin
sql: forbid diff. sorting orders in ORDER BY + LIMIT
aa4a2de 
Without multi-directional iterators (to be introduced in #3309)
ORDER BY + LIMIT with different specified ordered leads to wrong
result. So for now (till #3309 is resolved) different sort
orders are forbidden in ORDER BY + LIMIT.

Close #4038

@TarantoolBot document
Title: different sorting orders in ORDER BY are forbidden now
The error will be raised if different sorting orders are
encountered.
@kyukhin kyukhin modified the milestones: 2.2.0, 2.3.0 Apr 1, 2019
@kostja kostja modified the milestones: 2.3.1, 2.4.0 Aug 6, 2019
@kyukhin kyukhin added 13sp and removed prio1 labels Nov 18, 2020
@kyukhin kyukhin modified the milestones: 2.7.1, wishlist Nov 20, 2020
@kyukhin kyukhin modified the milestones: wishlist, 2.8.1 Dec 23, 2020
@alyapunov alyapunov added 21sp and removed 13sp labels Dec 24, 2020
@kyukhin kyukhin removed the tmp label Feb 12, 2021
@kyukhin kyukhin modified the milestones: 2.8.1, 2.9.1 Feb 20, 2021
@kyukhin kyukhin added the tmp label Feb 20, 2021
@kyukhin kyukhin removed the tmp label Apr 30, 2021
@kyukhin kyukhin modified the milestones: 2.9.1, wishlist Aug 19, 2021
@tsafin tsafin mentioned this issue Dec 28, 2021
Closed
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Feb 18, 2022
@ImeevMA
sql: allow LIMIT with different sorting order
644f68d 
This patch allows LIMIT to be used with a different sort order in
ORDER BY. This is a temporary solution and should be changed after
issue tarantool#3309 is fixed.

Closes tarantool#6664
@ImeevMA ImeevMA mentioned this issue Feb 18, 2022
Merged
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Feb 18, 2022
@ImeevMA
sql: allow LIMIT with different sorting order
7801f1c 
This patch allows LIMIT to be used with a different sort order in
ORDER BY. This is a temporary solution and should be changed after
issue tarantool#3309 is fixed.

Closes tarantool#6664
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Feb 18, 2022
@ImeevMA
sql: allow LIMIT with different sorting order
c1866e2 
This patch allows LIMIT to be used with a different sort order in
ORDER BY. This is a temporary solution and should be changed after
issue tarantool#3309 is fixed.

NO_DOC=It is fix of existing feature

Closes tarantool#6664
kyukhin pushed a commit that referenced this issue Feb 24, 2022
@ImeevMA @kyukhin
sql: allow LIMIT with different sorting order
34e57fe 
This patch allows LIMIT to be used with a different sort order in
ORDER BY. This is a temporary solution and should be changed after
issue #3309 is fixed.

NO_DOC=It is fix of existing feature

Closes #6664
@alyapunov alyapunov removed the 21sp label Feb 8, 2023
@TarantoolBot TarantoolBot removed the teamC label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new functionality
Projects
None yet
Milestone
wishlist
Development

No branches or pull requests
8 participants
@nodermann @kostja @zilveer @alyapunov @kyukhin @SudoBobo @Korablev77 @TarantoolBot