Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql.exequte arg substitution (parameter binding) #3401

Closed
Khatskevich opened this issue May 15, 2018 · 2 comments
Closed

sql.exequte arg substitution (parameter binding) #3401

Khatskevich opened this issue May 15, 2018 · 2 comments
Assignees
@ImeevMA
Labels
bug Something isn't working sql
Milestone
2.1.2

Comments

@Khatskevich
Copy link
Contributor

While perf measuring I found out that It is impossible to bind parameters in sql query from Lua as it is implemented in iproto.

cn:execute('select ?, ?, ?, ?, ?', {'abc', -123.456, msgpack.NULL, true, false})

This is an important feature because Lua concatenates strings very slowly.
@Khatskevich Khatskevich added feature A new functionality sql labels May 15, 2018
@kyukhin kyukhin added this to the 2.1.1 milestone May 15, 2018
@kyukhin kyukhin added the prio1 label Nov 13, 2018
@kostja kostja added bug Something isn't working and removed feature A new functionality labels Nov 19, 2018
@Gerold103
Copy link
Collaborator

Part of #3505

ImeevMA added a commit that referenced this issue Nov 27, 2018
@ImeevMA
lua: create vstream implementation for Lua
cbd6886 
Thas patch creates vstream implementation for Lua and function
box.sql.new_execute() that uses this implementation. Also it
creates parameters binding for SQL statements executed through
box.

Part of #3505
Closes #3401
Gerold103 pushed a commit that referenced this issue Nov 28, 2018
@ImeevMA @Gerold103
lua: create vstream implementation for Lua
0008c79 
Thas patch creates vstream implementation for Lua and function
box.sql.new_execute() that uses this implementation. Also it
creates parameters binding for SQL statements executed through
box.

Part of #3505
Closes #3401
ImeevMA added a commit that referenced this issue Nov 30, 2018
@ImeevMA
lua: create vstream implementation for Lua
4675788 
Thas patch creates vstream implementation for Lua and function
box.sql.new_execute() that uses this implementation. Also it
creates parameters binding for SQL statements executed through
box.

Part of #3505
Closes #3401
ImeevMA added a commit that referenced this issue Dec 21, 2018
@ImeevMA
sql: parameter binding for new execute()
62c5658 
This patch defines parameters binding for SQL statements executed
through box.

Part of #3505
Closes #3401
ImeevMA added a commit that referenced this issue Dec 22, 2018
@ImeevMA
sql: parameter binding for new execute()
db9601d 
This patch defines parameters binding for SQL statements executed
through box.

Part of #3505
Closes #3401
ImeevMA added a commit that referenced this issue Dec 28, 2018
@ImeevMA
lua: parameter binding for new execute()
a1fe2aa 
This patch defines parameters binding for SQL statements executed
through box.

Part of #3505
Closes #3401
ImeevMA added a commit that referenced this issue Jan 15, 2019
@ImeevMA
lua: parameter binding for new execute()
544b9b2 
This patch defines parameters binding for SQL statements executed
through box.

Part of #3505
Closes #3401
ImeevMA added a commit that referenced this issue Jan 19, 2019
@ImeevMA
lua: parameter binding for new execute()
f5240e1 
This patch defines parameters binding for SQL statements executed
through box.

Part of #3505
Closes #3401
@kyukhin kyukhin removed the prio1 label Mar 19, 2019
@kyukhin kyukhin added the tmp label Mar 29, 2019
ImeevMA added a commit that referenced this issue Mar 30, 2019
@ImeevMA
sql: parameter binding for box.execute()
884040a 
This patch defines parameters binding for SQL statements executed
through box.execute().

Closes #3401
Gerold103 pushed a commit that referenced this issue Mar 30, 2019
@ImeevMA @Gerold103
sql: parameter binding for box.execute()
72c7b06 
This patch defines parameters binding for SQL statements executed
through box.execute().

Closes #3401
Gerold103 pushed a commit that referenced this issue Apr 1, 2019
@ImeevMA @Gerold103
sql: parameter binding for box.execute()
01d0c73 
This patch defines parameters binding for SQL statements executed
through box.execute().

Closes #3401
Gerold103 pushed a commit that referenced this issue Apr 2, 2019
@ImeevMA @Gerold103
sql: parameter binding for box.execute()
a4a1daa 
This patch defines parameters binding for SQL statements executed
through box.execute().

Closes #3401
@kyukhin kyukhin closed this as completed in 9cff397 Apr 2, 2019
kyukhin pushed a commit that referenced this issue Apr 2, 2019
@ImeevMA @kyukhin
sql: parameter binding for box.execute()
90200e1 
This patch defines parameters binding for SQL statements executed
through box.execute().

Closes #3401

(cherry picked from commit 9cff397)
Totktonada pushed a commit that referenced this issue Jun 14, 2019
@ImeevMA @Totktonada
sql: parameter binding for box.execute()
c0a6285 
This patch defines parameters binding for SQL statements executed
through box.execute().

Closes #3401

(cherry picked from commit 9cff397)
Totktonada pushed a commit that referenced this issue Jun 14, 2019
@ImeevMA @Totktonada
sql: parameter binding for box.execute()
0f440a9 
This patch defines parameters binding for SQL statements executed
through box.execute().

Closes #3401

(cherry picked from commit 9cff397)
@Totktonada
Copy link
Member

Now cherry-picked to 2.1 too (it seems it was not made before due to a mistake).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImeevMA ImeevMA

Labels
bug Something isn't working sql
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
7 participants
@Totktonada @kostja @locker @Gerold103 @ImeevMA @Khatskevich @kyukhin