Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work with 'IF NOT EXISTS' in VDBE #3435

Closed
kshcherbatov opened this issue May 30, 2018 · 2 comments
Closed

Work with 'IF NOT EXISTS' in VDBE #3435

kshcherbatov opened this issue May 30, 2018 · 2 comments
Assignees
@kshcherbatov
Labels
ddl refactoring Code refactoring sql
Milestone
2.1.0

Comments

@kshcherbatov
Copy link
Contributor

Now IF NOT EXISTS construction is processed on Parser prepare step. It is invalid as prepared bytecode could be called multiple times with different database states.
@kshcherbatov kshcherbatov self-assigned this May 30, 2018
@kshcherbatov kshcherbatov added this to the 2.1.0 milestone May 30, 2018
@Gerold103
Copy link
Collaborator

Not only because of multiple executions. When the parser does some functional and storage dependent things it is impossible to extract it to a library and use on client side.

@Gerold103 Gerold103 removed this from the 2.1.0 milestone May 30, 2018
kshcherbatov added a commit that referenced this issue Jun 9, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
34f7679 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration.

Part of #3435, #3273
@kyukhin kyukhin added this to the 2.1.0 milestone Jun 13, 2018
kshcherbatov added a commit that referenced this issue Jun 14, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
2dc4c35 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration.

Part of #3435, #3273
Gerold103 pushed a commit that referenced this issue Jun 14, 2018
@kshcherbatov @Gerold103
sql: VDBE tests for trigger existence
f33ce06 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 15, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
dc61154 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration.

Part of #3435, #3273
Gerold103 pushed a commit that referenced this issue Jun 18, 2018
@kshcherbatov @Gerold103
sql: VDBE tests for trigger existence
a2bbfd4 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 18, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
0d37521 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 19, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
db0515f 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 20, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
784b338 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 20, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
8bb4945 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 25, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
c48f9ff 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 26, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
f600824 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 26, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
f0d0aed 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 26, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
992eb6b 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 27, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
cff35c8 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 27, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
ec2d373 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 27, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
85b9878 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 28, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
8dd4f75 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
kshcherbatov added a commit that referenced this issue Jun 29, 2018
@kshcherbatov
sql: VDBE tests for trigger existence
0d52f71 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
kyukhin pushed a commit that referenced this issue Jun 29, 2018
@kshcherbatov @kyukhin
sql: VDBE tests for trigger existence
5b7970b 
Trigger presence in system should be tested on each VDBE
execution attempt, not on Parser iteration as system state
could be changed between opcode run.
With this patch, such checks are the part of VDBE program
looking to the _trigger space and raise error message if
tuple with specified key already exists.

Part of #3435, #3273
@kyukhin
Copy link
Contributor

kyukhin commented Jul 2, 2018

Fixed w/ #3273 resolution.

@kyukhin kyukhin closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshcherbatov kshcherbatov

Labels
ddl refactoring Code refactoring sql
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@Gerold103 @kshcherbatov @kyukhin