Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sqlite 32 column mask with our smart 64 bit one #3571

Closed
Gerold103 opened this issue Jul 26, 2018 · 0 comments
Closed

Replace sqlite 32 column mask with our smart 64 bit one #3571

Gerold103 opened this issue Jul 26, 2018 · 0 comments
Assignees
@kshcherbatov
Labels
good first issue Good for newcomers refactoring Code refactoring sql
Milestone
2.2.0

Comments

@Gerold103
Copy link
Collaborator

Column mask in Tarantool is not just 32 bits greater, but also it is smarter. When a column with number > 63 is added to the mask, the only last bit (64th) is set indicating the overflow. SQLite mask in such a case just resets the whole mask in -1.

Lets replace sqlite column mask with our one in all places.
@Gerold103 Gerold103 added refactoring Code refactoring sql good first issue Good for newcomers labels Jul 26, 2018
@kyukhin kyukhin added this to the 2.1.1 milestone Jul 30, 2018
kshcherbatov added a commit that referenced this issue Aug 30, 2018
@kshcherbatov
sql: replace sql column mask with core mask
cc088d9 
Refactored SQL Bitmask with tarantool core uint64_t column mask
and API functions.

Closes #3571.
@kyukhin kyukhin modified the milestones: 2.1.1, 2.2.0 Nov 26, 2018
kshcherbatov added a commit that referenced this issue Feb 8, 2019
@kshcherbatov
box: introduce new helpers in column_mask.h
e7ff60b 
Refactored column_mask.h definitions: introduced a new routine
column_mask_is_overflowed, column_mask_is_set and macro
COLUMN_MASK_BIT, COLUMN_MASK_SIZE.
We need this helpers in further refactoring.

Needed for #3571
kshcherbatov added a commit that referenced this issue Feb 8, 2019
@kshcherbatov
sql: use 64b bitmasks instead of 32b where possible
26ee3cd 
In some cases(like foreign keys) the SQL code is still used
32-bit bit mask, while 64-bit bit masks will perform better
column optimizations. There was refactored code to work with 64b
bitmasks where required.
The 32b bitmasks are still used to specify constant OP_Function
arguments because this change would require changing the P1 type
of the VDBE p1 argument, which is not desirable. Moreover, the
64 function's arguments is an explicit overkill.

Part of #3571
kshcherbatov added a commit that referenced this issue Feb 8, 2019
@kshcherbatov
sql: got rid of redundant MASKBIT32 definition
4330bed 
MASK BIT 32 macro is now redundant, so we got rid of it.
Also refactored related code to use core bitmasks helpers

Part of #3571
kshcherbatov added a commit that referenced this issue Feb 8, 2019
@kshcherbatov
sql: got rid of redundant bitmask helpers
6851ecb 
The original SQLite code allowed the program to be compiled using
32-bit masks to save disk space. Since we are not going to
compile Tarantool in such way, we will get rid of these macros by
replacing them(where possible) with helpers from column_mask.h

Closes #3571
kshcherbatov added a commit that referenced this issue Feb 20, 2019
@kshcherbatov
box: introduce new helpers in column_mask.h
9890b1f 
Refactored column_mask.h definitions: introduced a new routine
column_mask_is_overflowed, column_mask_is_set and macro
COLUMN_MASK_BIT, COLUMN_MASK_SIZE.
We need this helpers in further refactoring.

Needed for #3571
kshcherbatov added a commit that referenced this issue Feb 20, 2019
@kshcherbatov
sql: use 64b bitmasks instead of 32b where possible
baf9e24 
In some cases(like foreign keys) the SQL code is still used
32-bit bit mask, while 64-bit bit masks will perform better
column optimizations. There was refactored code to work with 64b
bitmasks where required.
The 32b bitmasks are still used to specify constant OP_Function
arguments because this change would require changing the P1 type
of the VDBE p1 argument, which is not desirable. Moreover, the
64 function's arguments is an explicit overkill.

Part of #3571
kshcherbatov added a commit that referenced this issue Feb 20, 2019
@kshcherbatov
sql: get rid of redundant MASKBIT32 definition
95cf6fb 
MASK BIT 32 macro is now redundant, so we got rid of it.
Also refactored related code to use core bitmasks helpers

Part of #3571
kshcherbatov added a commit that referenced this issue Feb 20, 2019
@kshcherbatov
sql: get rid of redundant bitmask helpers
5eab67f 
The original SQLite code allowed the program to be compiled using
32-bit masks to save disk space. Since we are not going to
compile Tarantool in such way, we will get rid of these macros by
replacing them(where possible) with helpers from column_mask.h

Closes #3571
kshcherbatov added a commit that referenced this issue Feb 20, 2019
@kshcherbatov
box: introduce new helpers in column_mask.h
b3de0ef 
Refactored column_mask.h definitions: introduced a new routine
column_mask_is_overflowed, column_mask_is_set. Also a couple of
routines for 32-bit bitmask.
We need this helpers in further refactoring.

Needed for #3571
kshcherbatov added a commit that referenced this issue Feb 20, 2019
@kshcherbatov
sql: use 64b bitmasks instead of 32b where possible
adc57c6 
In some cases(like foreign keys) the SQL code is still used
32-bit bit mask, while 64-bit bit masks will perform better
column optimizations. There was refactored code to work with 64b
bitmasks where required.
The 32b bitmasks are still used to specify constant OP_Function
arguments because this change would require changing the P1 type
of the VDBE p1 argument, which is not desirable. Moreover, the
64 function's arguments is an explicit overkill.

Part of #3571
kshcherbatov added a commit that referenced this issue Feb 20, 2019
@kshcherbatov
sql: get rid of redundant MASKBIT32 definition
4f6f6f0 
MASK BIT 32 macro is now redundant, so we got rid of it.
Also refactored related code to use core bitmasks helpers

Part of #3571
kshcherbatov added a commit that referenced this issue Feb 20, 2019
@kshcherbatov
sql: get rid of redundant bitmask helpers
c7c0e54 
The original SQLite code allowed the program to be compiled using
32-bit masks to save disk space. Since we are not going to
compile Tarantool in such way, we will get rid of these macros by
replacing them(where possible) with helpers from column_mask.h

Closes #3571
kshcherbatov added a commit that referenced this issue Mar 20, 2019
@kshcherbatov
sql: use 64b bitmasks instead of 32b where possible
84e81d5 
In some cases(like foreign keys) the SQL code used
32-bit bit mask, while 64-bit bit masks will perform better
column optimizations. There was refactored code to work with 64b
bitmasks where required.
The 32b bitmasks are still used to specify constant OP_Function
arguments because this change would require changing the P1 type
of the VDBE p1 argument, which is not desirable. Moreover, the
64 function's arguments is an explicit overkill.

The ticket was created in connection with the introduction of
foreign keys and their use of 32-bit bit masks. In the rest of
the scripts in SQL already use 64 bit masks, and the "smart" bit
of the mask is not applicable.

Closes #3571
kshcherbatov added a commit that referenced this issue Mar 27, 2019
@kshcherbatov
sql: use 64b bitmasks instead of 32b where possible
ee798f6 
In some cases(like foreign keys) the SQL code used
32-bit bit mask, while 64-bit bit masks will perform better
column optimizations. There was refactored code to work with 64b
bitmasks where required.
The 32b bitmasks are still used to specify constant OP_Function
arguments because this change would require changing the P1 type
of the VDBE p1 argument, which is not desirable. Moreover, the
64 function's arguments is an explicit overkill.

The ticket was created in connection with the introduction of
foreign keys and their use of 32-bit bit masks. In the rest of
the scripts in SQL already use 64 bit masks, and the "smart" bit
of the mask is not applicable.

Closes #3571
@kyukhin kyukhin added the tmp label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshcherbatov kshcherbatov

Labels
good first issue Good for newcomers refactoring Code refactoring sql
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
4 participants
@locker @Gerold103 @kshcherbatov @kyukhin