Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rocks remove --force option #3632

Closed
mtrempoltsev opened this issue Aug 21, 2018 · 2 comments
Closed

Implement rocks remove --force option #3632

mtrempoltsev opened this issue Aug 21, 2018 · 2 comments
Assignees
@LeonidVas
Labels
bug Something isn't working tarantoolctl
Milestone
2.5.1

Comments

@mtrempoltsev
Copy link 

ib-core $ tarantoolctl rocks remove logger
Checking stability of dependencies in the absence of
logger scm-1...

Will not remove logger scm-1.
Removing it would break dependencies for:
ib-core scm-1

Use --force to force removal (warning: this may break modules).

Error: Failed removing.
ib-core $ tarantoolctl rocks remove logger --force
builtin/internal.argparse.lua:142: unknown options: force
@kyukhin kyukhin added the bug Something isn't working label Aug 24, 2018
@kyukhin kyukhin added this to the 1.10.3 milestone Aug 24, 2018
@rosik rosik mentioned this issue Oct 18, 2018
Closed
@kyukhin kyukhin modified the milestones: 1.10.3, 1.10.4 Apr 1, 2019
@Totktonada
Copy link
Member

Totktonada commented Jun 16, 2019 •
edited
Loading

I think we should allow all or most of luarocks options to be passed to subcommands.

However we maybe should ban --lua-ver[sion], --lua-dir and other options that are related to choosing a Lua interpreter to configure packages against (don't sure however what exactly this 'configuration' does).

Don't forget to remove banned options from tarantoolctl rocks help [subcommand] output.

@Totktonada Totktonada mentioned this issue Jun 16, 2019
Merged
@kyukhin kyukhin added feature A new functionality and removed bug Something isn't working labels Aug 6, 2019
@kyukhin kyukhin modified the milestones: 1.10.4, 2.4.0 Aug 6, 2019
@rosik rosik mentioned this issue Nov 13, 2019
Closed
@LeonidVas LeonidVas self-assigned this Nov 18, 2019
LeonidVas added a commit that referenced this issue Feb 25, 2020
@LeonidVas
luarocks: add a kludge for option force of luarocks remove
82a99e8 
Fixes: #3632
LeonidVas added a commit that referenced this issue Mar 16, 2020
@LeonidVas
luarocks: Add a kludge for option force of luarocks remove
8924769 
Fixed the tarantoolctl rocks remove flag --force

Forwarding of the --force flag to tarantoolctl rocks module was added.
(Command: tarantoolctl rocks remove --force)

Fixes: #3632
LeonidVas added a commit that referenced this issue Mar 16, 2020
@LeonidVas
luarocks: Add a kludge for option force of luarocks remove
1c4da49 
Fixed the tarantoolctl rocks remove flag --force

Forwarding of the --force flag to tarantoolctl rocks module was added.
(Command: tarantoolctl rocks remove --force)

Fixes: #3632
@kyukhin kyukhin modified the milestones: 2.4.1, 2.5.1 Mar 26, 2020
LeonidVas added a commit that referenced this issue Apr 1, 2020
@LeonidVas
luarocks: Add a kludge for option force of luarocks remove
797216b 
Fixed the tarantoolctl rocks remove flag --force

Forwarding of the --force flag to tarantoolctl rocks module was added.
(Command: tarantoolctl rocks remove --force)

Fixes: #3632
LeonidVas added a commit that referenced this issue Apr 2, 2020
@LeonidVas
luarocks: Add a kludge for option force of luarocks remove
0e8d818 
@Changelog
Fixed the tarantoolctl rocks remove flag --force

Forwarding of the --force flag to tarantoolctl rocks module was added.
(Command: tarantoolctl rocks remove --force)

Fixes: #3632
@kyukhin kyukhin added bug Something isn't working and removed feature A new functionality labels Apr 2, 2020
@kyukhin kyukhin closed this as completed in 6ef13c6 Apr 2, 2020
kyukhin pushed a commit that referenced this issue Apr 2, 2020
@LeonidVas @kyukhin
luarocks: Add a kludge for option force of luarocks remove
64737b2 
@Changelog
Fixed the tarantoolctl rocks remove flag --force

Forwarding of the --force flag to tarantoolctl rocks module was added.
(Command: tarantoolctl rocks remove --force)

Fixes: #3632
(cherry picked from commit 6ef13c6)
kyukhin pushed a commit that referenced this issue Apr 2, 2020
@LeonidVas @kyukhin
luarocks: Add a kludge for option force of luarocks remove
2f59611 
@Changelog
Fixed the tarantoolctl rocks remove flag --force

Forwarding of the --force flag to tarantoolctl rocks module was added.
(Command: tarantoolctl rocks remove --force)

Fixes: #3632
(cherry picked from commit 6ef13c6)
LeonidVas added a commit that referenced this issue Apr 2, 2020
@LeonidVas
luarocks: Add a kludge for option force of luarocks remove
f569484 
@Changelog
Fixed the tarantoolctl rocks remove flag --force (#3632)

Forwarding of the --force flag to tarantoolctl rocks module was added.
(Command: tarantoolctl rocks remove --force)

Fixes: #3632
Totktonada pushed a commit that referenced this issue Apr 9, 2020
@LeonidVas @Totktonada
luarocks: Add a kludge for option force of luarocks remove
84dd4f5 
@Changelog
Fixed the tarantoolctl rocks remove flag --force

Forwarding of the --force flag to tarantoolctl rocks module was added.
(Command: tarantoolctl rocks remove --force)

Fixes: #3632
(cherry picked from commit 6ef13c6)
@Totktonada
Copy link
Member

Pushed to 1.10 too in 1.10.5-48-g84dd4f57d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeonidVas LeonidVas

Labels
bug Something isn't working tarantoolctl
Projects
None yet
Milestone
2.5.1
Development

No branches or pull requests
4 participants
@Totktonada @mtrempoltsev @kyukhin @LeonidVas