Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fail wiith a statement that may fall through #3658

Closed
pgulutzan opened this issue Aug 31, 2018 · 0 comments
Closed

Build fail wiith a statement that may fall through #3658

pgulutzan opened this issue Aug 31, 2018 · 0 comments
Labels
Milestone

Comments

@pgulutzan
Copy link
Contributor

I have Ubuntu 18.04 and Tarantool 2.0, pulled from source today.
The gcc version is 7.3.0, and there have been changes affecting switches
https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/

When I use default cmake and make I see:
[ 34%] Building C object src/box/sql/CMakeFiles/sql.dir/insert.c.o
/home/pgulutzan/tarantool-2.0/src/box/sql/insert.c: In function ‘vdbe_emit_constraint_checks’:
/home/pgulutzan/tarantool-2.0/src/box/sql/insert.c:893:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
sqlite3MayAbort(parse_context);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/pgulutzan/tarantool-2.0/src/box/sql/insert.c:894:3: note: here
case ON_CONFLICT_ACTION_ROLLBACK:
^~~~
cc1: all warnings being treated as errors
src/box/sql/CMakeFiles/sql.dir/build.make:446: recipe for target 'src/box/sql/CMakeFiles/sql.dir/insert.c.o' failed
make[2]: *** [src/box/sql/CMakeFiles/sql.dir/insert.c.o] Error 1

Totktonada added a commit that referenced this issue Sep 3, 2018
-Wimplicit-fallthrough is enabled by -Wextra on GCC 7, so it breaks our
Debug build with this version of the compiler.

Fixes #3658.
@kyukhin kyukhin added bug Something isn't working build labels Sep 5, 2018
@kyukhin kyukhin added this to the 2.1.0 milestone Sep 5, 2018
@kyukhin kyukhin closed this as completed in 47969ef Sep 5, 2018
@kyukhin kyukhin removed bug Something isn't working labels Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants