Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1pt] Tagged releases are not uploaded (extra commit is needed) #3745

Closed
Totktonada opened this issue Oct 15, 2018 · 10 comments
Closed

[1pt] Tagged releases are not uploaded (extra commit is needed) #3745

Totktonada opened this issue Oct 15, 2018 · 10 comments
Assignees
@Totktonada @avtikhon
Labels
qa Issues related to tests or testing subsystem
Milestone
QA

Comments

@Totktonada
Copy link
Member

travis-ci/travis-ci#7780 (comment)
@Totktonada
Copy link
Member Author

We have the same problems with modules (say, avro-schema).

@Totktonada Totktonada added the qa Issues related to tests or testing subsystem label Oct 16, 2018
@kyukhin kyukhin added this to the QA milestone Oct 25, 2018
@bofm bofm mentioned this issue May 29, 2019
Merged
Totktonada added a commit that referenced this issue Jun 14, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
af29af7 
The problem was that a tagged revision is not deployed, so after a
release we did an empty commit to trigger deployment. Now it is worked
around by adding extra deployment rules that deploys tagged revisions.
The workaround was suggested by Hiro Asari in [1].

[1]: travis-ci/travis-ci#7780 (comment)

Fixes #3745.
Totktonada added a commit to tarantool/memcached that referenced this issue Jul 24, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
6c5736a 
See tarantool/tarantool#3745
Totktonada added a commit to tarantool/small that referenced this issue Jul 25, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
d42845b 
See tarantool/tarantool#3745
Totktonada added a commit to tarantool/small that referenced this issue Jul 25, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
9046d88 
See tarantool/tarantool#3745
Totktonada added a commit that referenced this issue Jul 26, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
c33d274 
The problem was that a tagged revision is not deployed, so after a
release we did an empty commit to trigger deployment. Now it is worked
around by adding extra deployment rules that deploys tagged revisions.
The workaround was suggested by Hiro Asari in [1].

[1]: travis-ci/travis-ci#7780 (comment)

Fixes #3745.

(cherry picked from commit 2fe7036)
Totktonada added a commit that referenced this issue Jul 26, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
1aa8b92 
The problem was that a tagged revision is not deployed, so after a
release we did an empty commit to trigger deployment. Now it is worked
around by adding extra deployment rules that deploys tagged revisions.
The workaround was suggested by Hiro Asari in [1].

[1]: travis-ci/travis-ci#7780 (comment)

Fixes #3745.

(cherry picked from commit 2fe7036)
Totktonada added a commit to tarantool/memcached that referenced this issue Jul 29, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
545e961 
See tarantool/tarantool#3745

Part of #49.
Totktonada added a commit to tarantool/memcached that referenced this issue Jul 29, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
ef58b9b 
See tarantool/tarantool#3745

Part of #49.
Totktonada added a commit to tarantool/pg that referenced this issue Jul 30, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
730469b 
See tarantool/tarantool#3745
Totktonada added a commit to tarantool/pg that referenced this issue Jul 30, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
3e0efaa 
See tarantool/tarantool#3745
Totktonada added a commit to stefansaraev/mqtt that referenced this issue Jul 31, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
1f3b215 
See tarantool/tarantool#3745
Totktonada added a commit to tarantool/mqtt that referenced this issue Jul 31, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
6fd3088 
See tarantool/tarantool#3745
Totktonada added a commit to stefansaraev/expirationd that referenced this issue Jul 31, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
1fa9eaf 
See tarantool/tarantool#3745
Totktonada added a commit to tarantool/expirationd that referenced this issue Jul 31, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
74b9b16 
See tarantool/tarantool#3745
avtikhon added a commit to tarantool/queue that referenced this issue Aug 2, 2019
@avtikhon
travis-ci: update distros and repos
89a16c1 
Removed release repos:
    1_7/1_9.
Added the build distros:
    Fedora 30, Ubuntu 19.04, Debian 10.
Removed the build distros:
    Fedora 26,27.
Deploy packages from tagged revisions, see:
    tarantool/tarantool#3745

Closes #94
Totktonada added a commit to tarantool/queue that referenced this issue Aug 6, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
c18b1ce 
See tarantool/tarantool#3745
Totktonada added a commit to tarantool/queue that referenced this issue Aug 6, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
445da1d 
See tarantool/tarantool#3745
avtikhon added a commit to tarantool/mysql that referenced this issue Aug 20, 2019
@avtikhon
travis-ci: update distros and repos
628336c 
Removed release repos:
    1_6, 1_7.
Added release repos:
    1_10, 2x, 2_2, 2_3.
Added the build distros:
    Fedora 30, Ubuntu 19.04, Debian 10.
Deploy packages from tagged revisions, see:
    tarantool/tarantool#3745

Closes #26
Totktonada pushed a commit to tarantool/mysql that referenced this issue Aug 20, 2019
@avtikhon @Totktonada
travis-ci: update distros and repos
0b2921f 
Removed release repos:
    1_6, 1_7.
Added release repos:
    1_10, 2x, 2_2, 2_3.
Added the build distros:
    Fedora 30, Ubuntu 19.04, Debian 10.
Deploy packages from tagged revisions, see:
    tarantool/tarantool#3745

Closes #26
@Totktonada
Copy link
Member Author

We should also enable tarball and package jobs on tagged revisions, because, say, if: branch = "master" does not enable them on tagged revisions.

@Totktonada Totktonada reopened this Sep 26, 2019
Totktonada added a commit to tarantool/avro-schema that referenced this issue Oct 23, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
5b8911d 
See tarantool/tarantool#3745
Totktonada added a commit to tarantool/avro-schema that referenced this issue Oct 23, 2019
@Totktonada
travis-ci: deploy packages from tagged revisions
e90fe20 
See tarantool/tarantool#3745
@Totktonada Totktonada mentioned this issue Nov 9, 2019
Closed
@Totktonada Totktonada mentioned this issue Apr 28, 2020
Closed
avtikhon added a commit that referenced this issue Oct 8, 2020
@avtikhon
packages: tagged commit force push to live repo
029eade 
If the commit tagged, then push packages to 'live' repository with force
push '-f -s' flags to be sure that if occasionaly the commit before current
commit pushed packages with the current branch naming then the current push
won't fail on it and will push the packages to the release repository after.

Closes #3745
@avtikhon avtikhon changed the title Tagged releases are not uploaded (extra commit is needed) [1pt] Tagged releases are not uploaded (extra commit is needed) Oct 9, 2020
avtikhon added a commit that referenced this issue Oct 14, 2020
@avtikhon
gitlab-ci: tagged commit force push to live repo
224b4c4 
If the commit tagged, then push packages to 'live' repository with force
push '-f -s' flags to be sure that if occasionaly the commit before current
commit pushed packages with the current branch naming then the current push
won't fail on it and will push the packages to the release repository after.

Part of #3745
avtikhon added a commit that referenced this issue Oct 14, 2020
@avtikhon @Totktonada
gitlab-ci: remove tag from pushed branch commit
8c07da5 
Drop a tag that points to a current commit (if any) on a job triggered
by pushing to a branch (as against of pushing a tag). Otherwise we may
get two jobs for the same x.y.z-0-gxxxxxxxxx build: one is run by
pushing a branch and another by pushing a tag. The idea is to hide the
new tag from the branch job as if a tag would be pushed strictly after
all branch jobs for the same commit.

Closes #3745

Co-authored-by: Alexander Turenko <alexander.turenko@tarantool.org>
@Totktonada
Copy link
Member Author

More detailed description is in the mailing list.

Totktonada pushed a commit that referenced this issue Oct 14, 2020
@avtikhon @Totktonada
gitlab-ci: remove tag from pushed branch commit
579c81d 
Drop a tag that points to a current commit (if any) on a job triggered
by pushing to a branch (as against of pushing a tag). Otherwise we may
get two jobs for the same x.y.z-0-gxxxxxxxxx build: one is run by
pushing a branch and another by pushing a tag. The idea is to hide the
new tag from the branch job as if a tag would be pushed strictly after
all branch jobs for the same commit.

Closes #3745

Co-authored-by: Alexander Turenko <alexander.turenko@tarantool.org>
(cherry picked from commit 0f564f3)
Totktonada pushed a commit that referenced this issue Oct 14, 2020
@avtikhon @Totktonada
gitlab-ci: remove tag from pushed branch commit
c55225e 
Drop a tag that points to a current commit (if any) on a job triggered
by pushing to a branch (as against of pushing a tag). Otherwise we may
get two jobs for the same x.y.z-0-gxxxxxxxxx build: one is run by
pushing a branch and another by pushing a tag. The idea is to hide the
new tag from the branch job as if a tag would be pushed strictly after
all branch jobs for the same commit.

Closes #3745

Co-authored-by: Alexander Turenko <alexander.turenko@tarantool.org>
(cherry picked from commit 0f564f3)
Totktonada pushed a commit that referenced this issue Oct 14, 2020
@avtikhon @Totktonada
gitlab-ci: remove tag from pushed branch commit
7ff7d50 
Drop a tag that points to a current commit (if any) on a job triggered
by pushing to a branch (as against of pushing a tag). Otherwise we may
get two jobs for the same x.y.z-0-gxxxxxxxxx build: one is run by
pushing a branch and another by pushing a tag. The idea is to hide the
new tag from the branch job as if a tag would be pushed strictly after
all branch jobs for the same commit.

Closes #3745

Co-authored-by: Alexander Turenko <alexander.turenko@tarantool.org>
(cherry picked from commit 0f564f3)
@Totktonada
Copy link
Member Author

  • x.y.z.0 RPM / Deb packages are not deployed to packagecloud on 1.10 and 2.4. Not resolved (but is not important at all).

For the record: it is not resolved, but is not important.

  • x.y.z.0 RPM / Deb packages may be tried to upload twice (from a push job and from a tag job). Looks broken after 5aa1a1d.

It should be fixed.

avtikhon added a commit that referenced this issue Oct 15, 2020
@avtikhon @Totktonada
gitlab-ci: remove tag from pushed branch commit
5828641 
Drop a tag that points to a current commit (if any) on a job triggered
by pushing to a branch (as against of pushing a tag). Otherwise we may
get two jobs for the same x.y.z-0-gxxxxxxxxx build: one is run by
pushing a branch and another by pushing a tag. The idea is to hide the
new tag from the branch job as if a tag would be pushed strictly after
all branch jobs for the same commit.

Closes #3745

Co-authored-by: Alexander Turenko <alexander.turenko@tarantool.org>
avtikhon added a commit that referenced this issue Oct 15, 2020
@avtikhon
gitlab-ci: correct place of tag removement
b4f146e 
Found that branch commited tag removement added in:

  0f564f3 ("gitlab-ci: remove tag from pushed branch commit")

must be run after the current workspace was fetched. Also removed not
needed brackets from command to make it always pass.

Follows up #3745
avtikhon added a commit that referenced this issue Oct 15, 2020
@avtikhon
gitlab-ci: correct place of tag removement
2ed6356 
Found that branch commited tag removement added in:

  0f564f3 ("gitlab-ci: remove tag from pushed branch commit")

must be run after the current workspace was fetched. Also removed not
needed brackets from command to make it always pass.

Follows up #3745
Totktonada added a commit that referenced this issue Oct 15, 2020
@Totktonada @avtikhon
gitlab-ci: fix tag removal for a branch push job
0f575e0 
We should remove a tag after fetching of a remote repository.

It is hotfix of commit 0f564f3
('gitlab-ci: remove tag from pushed branch commit').

Follows up #3745

Co-authored-by: Alexander V. Tikhonov <avtikhon@tarantool.org>
Totktonada added a commit that referenced this issue Oct 15, 2020
@Totktonada
gitlab-ci: fix tag removal for a branch push job
2fb358d 
We should remove a tag after fetching of a remote repository.

It is hotfix of commit 0f564f3
('gitlab-ci: remove tag from pushed branch commit').

Follows up #3745

Co-authored-by: Alexander V. Tikhonov <avtikhon@tarantool.org>
(cherry picked from commit 0f575e0)
Totktonada added a commit that referenced this issue Oct 15, 2020
@Totktonada
gitlab-ci: fix tag removal for a branch push job
63381df 
We should remove a tag after fetching of a remote repository.

It is hotfix of commit 0f564f3
('gitlab-ci: remove tag from pushed branch commit').

Follows up #3745

Co-authored-by: Alexander V. Tikhonov <avtikhon@tarantool.org>
(cherry picked from commit 0f575e0)
Totktonada added a commit that referenced this issue Oct 15, 2020
@Totktonada
gitlab-ci: fix tag removal for a branch push job
3aad99e 
We should remove a tag after fetching of a remote repository.

It is hotfix of commit 0f564f3
('gitlab-ci: remove tag from pushed branch commit').

Follows up #3745

Co-authored-by: Alexander V. Tikhonov <avtikhon@tarantool.org>
(cherry picked from commit 0f575e0)
Totktonada added a commit to tarantool/gentoo-overlay that referenced this issue Oct 29, 2020
@Totktonada
dev-db/tarantool: add October 2020 releases
dde2663 
* 1.10.8 -- LTS.
* 2.4.3 -- old stable, last release of 2.4 series.
* 2.5.2 -- stable.
* 2.6.1 -- beta.

Release notes:

* https://github.com/tarantool/tarantool/releases/tag/1.10.8
* https://github.com/tarantool/tarantool/releases/tag/2.4.3
* https://github.com/tarantool/tarantool/releases/tag/2.5.2
* https://github.com/tarantool/tarantool/releases/tag/2.6.1

We fixed the problem with deployment of tagged revisions ([1]), so
x.y.z.0 versions are here (not x.y.z.1 as it was for past releases).

[1]: tarantool/tarantool#3745
@Totktonada Totktonada mentioned this issue Oct 30, 2020
Closed
5 tasks
@Totktonada Totktonada mentioned this issue Dec 5, 2020
Closed
@Totktonada Totktonada mentioned this issue Apr 22, 2021
Closed
ligurio pushed a commit to tarantool/expirationd that referenced this issue Sep 22, 2021
@Totktonada @ligurio
travis-ci: deploy packages from tagged revisions
be6fe2d 
See tarantool/tarantool#3745
ligurio pushed a commit to tarantool/pg that referenced this issue Mar 25, 2022
@Totktonada @ligurio
travis-ci: deploy packages from tagged revisions
1c72a9f 
See tarantool/tarantool#3745
ligurio pushed a commit to tarantool/pg that referenced this issue Mar 25, 2022
@Totktonada @ligurio
travis-ci: deploy packages from tagged revisions
3b98854 
See tarantool/tarantool#3745
ligurio pushed a commit to tarantool/pg that referenced this issue Mar 25, 2022
@Totktonada @ligurio
travis-ci: deploy packages from tagged revisions
012d1a9 
See tarantool/tarantool#3745
ligurio pushed a commit to tarantool/pg that referenced this issue Mar 25, 2022
@Totktonada @ligurio
travis-ci: deploy packages from tagged revisions
5a5095c 
See tarantool/tarantool#3745
ligurio pushed a commit to tarantool/pg that referenced this issue Mar 25, 2022
@Totktonada @ligurio
travis-ci: deploy packages from tagged revisions
617dffd 
See tarantool/tarantool#3745
ArtDu pushed a commit to ArtDu/expirationd that referenced this issue May 10, 2022
@Totktonada @ArtDu
travis-ci: deploy packages from tagged revisions
a62cc3c 
See tarantool/tarantool#3745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Totktonada Totktonada

@avtikhon avtikhon

Labels
qa Issues related to tests or testing subsystem
Projects
None yet
Milestone
QA
Development

No branches or pull requests
3 participants
@Totktonada @kyukhin @avtikhon