Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-informative error message in box.tuple.update #3884

Closed
olegrok opened this issue Dec 14, 2018 · 1 comment
Closed

non-informative error message in box.tuple.update #3884

olegrok opened this issue Dec 14, 2018 · 1 comment
Assignees
@slumber
Labels
feature A new functionality
Milestone
2.4.1

Comments

@olegrok
Copy link
Collaborator

olegrok commented Dec 14, 2018 

box.schema.create_space('test')
box.space.test:create_index('id', {parts = {1, 'unsigned'}})
box.space.test:format({{'id', 'unsigned'}, {'field', 'string'}})
box.space.test:replace{1, 'name'}
tuple = box.space.test:get(1)

tarantool> tuple:upsert({{'=', 2, nil}})          -- or tuple:update({{'=', 2, nil}})
---
- error: Unknown UPDATE operation
...

I think this message is not informative, I don't have any useful information about my mistake.
@kostja
Copy link
Contributor

kostja commented Dec 14, 2018

Please make sure the implementation does not slow down updates for everybody.

@kyukhin kyukhin added the feature A new functionality label Dec 25, 2018
@kyukhin kyukhin added this to the 2.2.0 milestone Dec 25, 2018
@kyukhin kyukhin modified the milestones: 2.2.0, 2.3.0 Mar 27, 2019
@kyukhin kyukhin modified the milestones: 2.3.1, 2.4.0 Aug 6, 2019
@slumber slumber self-assigned this Nov 24, 2019
slumber added a commit that referenced this issue Nov 24, 2019
@slumber
box: fix non-informative update() error message
591dfe4 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "Wrong argument number".
Taking an actual issue into account, the problem is about
nil - box.NULL confusion, maybe we could consider giving some
kind of warning in this case.

Fixes: #3884
slumber added a commit that referenced this issue Nov 26, 2019
@slumber
tuple: fix non-informative update() error message
34d6c0f 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed. Also add checking for correct opcode.

Fixes #3884
slumber added a commit that referenced this issue Nov 26, 2019
@slumber
tuple: fix non-informative update() error message
d1f9f55 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed. Also add checking for correct opcode.

Fixes #3884
slumber added a commit that referenced this issue Nov 26, 2019
@slumber
tuple: fix non-informative update() error message
208f24d 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed. Also add checking for correct opcode.

Fixes #3884
slumber added a commit that referenced this issue Nov 28, 2019
@slumber
tuple: fix non-informative update() error message
426f57f 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed. Also add checking for correct opcode.

Fixes #3884
slumber added a commit that referenced this issue Nov 29, 2019
@slumber
tuple: fix non-informative update() error message
ae6eadb 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed. Also add checking for correct opcode.

Fixes #3884
slumber added a commit that referenced this issue Nov 29, 2019
@slumber
tuple: fix non-informative update() error message
23c7e5a 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed. Also add checking for correct opcode.

Fixes #3884
slumber added a commit that referenced this issue Nov 30, 2019
@slumber
tuple: fix non-informative update() error message
02ba769 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed. Also add checking for correct opcode.

Fixes #3884
slumber added a commit that referenced this issue Jan 9, 2020
@slumber
tuple: fix non-informative update() error message
446378a 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed, or poiniting out at invalid operation code.

Fixes #3884
slumber added a commit that referenced this issue Jan 9, 2020
@slumber
tuple: add argument length check for update()
49014b7 
Currently tuple_object:update() does not check the length
of operation string and just takes the first character
after decoding. This patch fixes this problem.

Follow-up #3884
slumber added a commit that referenced this issue Jan 9, 2020
@slumber
tuple: fix non-informative update() error message
29dd9dd 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed, or poiniting out at invalid operation code.

Fixes #3884
slumber added a commit that referenced this issue Jan 9, 2020
@slumber
tuple: add argument length check for update()
60eeea2 
Currently tuple_object:update() does not check the length
of operation string and just takes the first character
after decoding. This patch fixes this problem.

Follow-up #3884
slumber added a commit that referenced this issue Jan 13, 2020
@slumber
tuple: fix non-informative update() error message
da926b2 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed, or poiniting out at invalid operation code.

Fixes #3884
slumber added a commit that referenced this issue Jan 13, 2020
@slumber
tuple: add argument length check for update()
d19ec67 
Currently tuple_object:update() does not check the length
of operation string and just takes the first character
after decoding. This patch fixes this problem.

Follow-up #3884
kyukhin pushed a commit that referenced this issue Jan 13, 2020
@slumber @kyukhin
tuple: add argument length check for update()
b73fb42 
Currently tuple_object:update() does not check the length
of operation string and just takes the first character
after decoding. This patch fixes this problem.

Follow-up #3884
avtikhon pushed a commit to avtikhon/tarantool that referenced this issue Feb 3, 2020
@slumber @avtikhon
tuple: fix non-informative update() error message
dd0d1c1 
Calling tuple_object:update() with invalid argument number
yields 'Unknown UPDATE operation' error. Instead, we replace this
error with explicit "wrong argument number", mentioning which operation
failed, or poiniting out at invalid operation code.

Fixes tarantool#3884
avtikhon pushed a commit to avtikhon/tarantool that referenced this issue Feb 3, 2020
@slumber @avtikhon
tuple: add argument length check for update()
72038f2 
Currently tuple_object:update() does not check the length
of operation string and just takes the first character
after decoding. This patch fixes this problem.

Follow-up tarantool#3884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slumber slumber

Labels
feature A new functionality
Projects
None yet
Milestone
2.4.1
Development

No branches or pull requests
4 participants
@kostja @olegrok @kyukhin @slumber