Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion failed on log.log_format("json") #3946

Closed
olegrok opened this issue Jan 23, 2019 · 0 comments
Closed

Assertion failed on log.log_format("json") #3946

olegrok opened this issue Jan 23, 2019 · 0 comments
Assignees
@romanhabibov
Labels
bug Something isn't working crash
Milestone
2.1.2

Comments

@olegrok
Copy link
Collaborator

olegrok commented Jan 23, 2019 •
edited 

➜ git:(master) tarantool
Tarantool 2.1.1-185-gf583b6c82
type 'help' for interactive help
tarantool> log = require('log')
---
...

tarantool> log.log_format("json")
Assertion failed: (format_func == say_format_plain || log->type == SAY_LOGGER_STDERR || log->type == SAY_LOGGER_PIPE || log->type == SAY_LOGGER_FILE), function log_set_format, file /tmp/tarantool-20190123-11484-8akln6/src/say.c, line 175.
[1]    21018 abort      tarantool


➜ git:(master) tarantool --version
Tarantool 2.1.1-185-gf583b6c82
Target: Darwin-x86_64-Debug
Build options: cmake . -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/tarantool/HEAD-f583b6c_2 -DENABLE_BACKTRACE=ON
Compiler: /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++
C_FLAGS: -fexceptions -funwind-tables -fno-omit-frame-pointer -fno-stack-protector -fno-common -fopenmp -msse2 -std=c11 -Wall -Wextra -Wno-strict-aliasing -Wno-char-subscripts -Wno-format-truncation -Wno-cast-function-type -Werror
CXX_FLAGS: -fexceptions -funwind-tables -fno-omit-frame-pointer -fno-stack-protector -fno-common -fopenmp -msse2 -std=c++11 -Wall -Wextra -Wno-strict-aliasing -Wno-char-subscripts -Wno-format-truncation -Wno-cast-function-type -Werror
@olegrok olegrok changed the title Crash on log.log_format("json") Assertion failed on log.log_format("json") Feb 1, 2019
@kostja kostja added crash bug Something isn't working labels Feb 5, 2019
@kyukhin kyukhin added this to the 2.1.1 milestone Feb 8, 2019
romanhabibov added a commit that referenced this issue Mar 2, 2019
@romanhabibov
log: add missing assert into log_set_format()
91d7d24 
Add missing condition for json format into assert in log_set_format() function.

Closes #3946
romanhabibov added a commit that referenced this issue Mar 18, 2019
@romanhabibov
log: throw errors when "json" with syslog or boot log
d2cec22 
Add function returning logger info to throw errors from lua when "json" used with syslog or boot log.

Closes #3946
romanhabibov added a commit that referenced this issue Mar 23, 2019
@romanhabibov
say: throw errors when "json" with syslog or boot log
4156e75 
Add function returning logger type to throw error from lua when
"json" used with syslog.

Closes #3946
romanhabibov added a commit that referenced this issue Mar 25, 2019
@romanhabibov
say: throw errors when "json" with syslog or boot log
d6d4d70 
Add function returning logger type to throw error from lua
when "json" used with syslog.

Closes #3946
romanhabibov added a commit that referenced this issue Mar 25, 2019
@romanhabibov
say: throw error when "json" used with syslog
4bc9012 
Add function returning logger type to throw error from lua
when "json" used with syslog.

Closes #3946
@locker locker closed this as completed in 6bcff2b Mar 26, 2019
locker pushed a commit that referenced this issue Mar 26, 2019
@romanhabibov @locker
say: fix assertion in log_format when called for boot or syslog logger
c2e79de 
It's OK to use json format with the boot logger. As for syslog, let's
add a check to Lua's log_format() so that it fails gracefully rather
than raising an assertion.

Closes #3946

(cherry picked from commit 6bcff2b)
@kyukhin kyukhin added the tmp label Mar 29, 2019
@olegrok olegrok mentioned this issue Jun 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romanhabibov romanhabibov

Labels
bug Something isn't working crash
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
5 participants
@kostja @locker @olegrok @kyukhin @romanhabibov