Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.client: wrong error message #4136

Closed
olegrok opened this issue Apr 11, 2019 · 0 comments
Closed

http.client: wrong error message #4136

olegrok opened this issue Apr 11, 2019 · 0 comments
Assignees
@kshcherbatov
Labels
good first issue Good for newcomers

Comments

@olegrok
Copy link
Collaborator

olegrok commented Apr 11, 2019

Tarantool version: 2.1.1-185-gf583b6c82

doc:
image

tarantool:

tarantool> httpc.new():request()
---
- error: 'builtin/http.client.lua:297: request(method, url [, options]])'
...

Expect: error: 'builtin/http.client.lua:297: request(method, url [, body, options]])'
kshcherbatov added a commit that referenced this issue Apr 22, 2019
@kshcherbatov
box: updated httpc error message
0ea3591 
Previously Tarantool used to raise the confusing error message in
case of invalid usage of the httpc module. Fixed to follow the
current module API.

Closes #4136
kshcherbatov added a commit that referenced this issue Apr 22, 2019
@kshcherbatov
box: updated httpc error message
60a8b7e 
Previously Tarantool used to raise the confusing error message in
case of invalid usage of the httpc module. Fixed to follow the
current module API.

Closes #4136
kshcherbatov added a commit that referenced this issue Apr 22, 2019
@kshcherbatov
httpc: updated client error message
f70ef4f 
Previously Tarantool used to raise the confusing error message in
case of invalid usage of the httpc module. Fixed to follow the
current module API.

Closes #4136
kshcherbatov added a commit that referenced this issue Apr 22, 2019
@kshcherbatov
httpc: update client error message
d97acc3 
Previously Tarantool used to raise the confusing error message in
case of invalid usage of the httpc module. Fixed to follow the
current module API.

Closes #4136
kyukhin pushed a commit that referenced this issue Apr 23, 2019
@kshcherbatov @kyukhin
httpc: update client error message
c69c0a6 
Previously Tarantool used to raise the confusing error message in
case of invalid usage of the httpc module. Fixed to follow the
current module API.

Closes #4136

(cherry picked from commit 5ebf933)
locker pushed a commit that referenced this issue Mar 5, 2022
@kshcherbatov @locker
httpc: update client error message
9e3a651 
Previously Tarantool used to raise the confusing error message in
case of invalid usage of the httpc module. Fixed to follow the
current module API.

Closes #4136

(cherry picked from commit 5ebf933)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshcherbatov kshcherbatov

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@locker @olegrok @kshcherbatov