Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor box.execute to not throw #4390

Closed
kyukhin opened this issue Jul 30, 2019 · 0 comments
Closed

Refactor box.execute to not throw #4390

kyukhin opened this issue Jul 30, 2019 · 0 comments
Assignees
@ImeevMA
Labels
bug Something isn't working refactoring Code refactoring sql
Milestone
2.2.0

Comments

@kyukhin
Copy link
Contributor

kyukhin commented Jul 30, 2019

Currently box.execute uses exceptions mechanism to report an error.
According to Lua coding style it should use Go-style res, err = ....
@kyukhin kyukhin added bug Something isn't working refactoring Code refactoring sql labels Jul 30, 2019
@kyukhin kyukhin added this to the 2.2.0 milestone Jul 30, 2019
ImeevMA added a commit that referenced this issue Jul 30, 2019
@ImeevMA
sql: rework error handling in box.execute()
3a33349 
In accordance with the Lua coding style in Tarantool, all errors
returned in Lua should be returned using 'return nil, error'.
However, box.execute() throws an exception in case of an error.
This patch causes box.execute() to return an error, as described
in the coding style.

Closes #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
sql: rework error handling in box.execute()
07ed5de 
In accordance with the Lua coding style in Tarantool, all errors
returned in Lua should be returned using 'return nil, error'.
However, box.execute() throws an exception in case of an error.
This patch causes box.execute() to return an error, as described
in the coding style.

Closes #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
lua: new function luaT_return_error()
f01ecd3 
Currently, if we have to return errors using the format
'return nil, error', we must do it manually. Since this error
return method is described in our Lua coding style, it makes sense
to create a function that will return an error in this format.
This patch creates a function.

Needed for #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
sql: rework error handling in box.execute()
03d4912 
In accordance with the Lua coding style in Tarantool, all errors
returned in Lua should be returned using 'return nil, error'.
However, box.execute() throws an exception in case of an error.
This patch causes box.execute() to return an error, as described
in the coding style.

Closes #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
lua: new function luaT_return_error()
f2a3598 
Currently, if we have to return errors using the format
'return nil, error', we must do it manually. Since this error
return method is described in our Lua coding style, it makes sense
to create a function that will return an error in this format.
This patch creates a function.

Needed for #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
sql: rework error handling in box.execute()
b5d87b2 
In accordance with the Lua coding style in Tarantool, all errors
returned in Lua should be returned using 'return nil, error'.
However, box.execute() throws an exception in case of an error.
This patch causes box.execute() to return an error, as described
in the coding style.

Closes #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
lua: new function luaT_return_error()
555da33 
Currently, if we have to return errors using the format
'return nil, error', we must do it manually. Since this error
return method is described in our Lua coding style, it makes sense
to create a function that will return an error in this format.
This patch creates a function.

Needed for #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
sql: rework error handling in box.execute()
00ad5d0 
In accordance with the Lua coding style in Tarantool, all errors
returned in Lua should be returned using 'return nil, error'.
However, box.execute() throws an exception in case of an error.
This patch causes box.execute() to return an error, as described
in the coding style.

Closes #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
lua: new function luaT_push_nil_and_error()
49ea0b6 
Currently, if we have to return errors using the format
'return nil, error', we must do it manually. Since this error
return method is described in our Lua coding style, it makes sense
to create a function that will return an error in this format.
This patch creates a function.

Needed for #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
sql: rework error handling in box.execute()
a612b7e 
In accordance with the Lua coding style in Tarantool, all errors
returned in Lua should be returned using 'return nil, error'.
However, box.execute() throws an exception in case of an error.
This patch causes box.execute() to return an error, as described
in the coding style.

Closes #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
lua: new function luaT_push_nil_and_error()
06f6a8f 
Currently, if we have to return errors using the format
'return nil, error', we must do it manually. Since this error
return method is described in our Lua coding style, it makes sense
to create a function that will return an error in this format.
This patch creates mentioned function.

Needed for #4390
ImeevMA added a commit that referenced this issue Jul 31, 2019
@ImeevMA
sql: rework error handling in box.execute()
cfeabc3 
In accordance with the Lua coding style in Tarantool, all errors
returned in Lua should be returned using 'return nil, error'.
However, box.execute() throws an exception in case of an error.
This patch causes box.execute() to return an error, as described
in the coding style.

Closes #4390
Gerold103 pushed a commit that referenced this issue Aug 1, 2019
@ImeevMA @Gerold103
lua: new function luaT_push_nil_and_error()
ee3d675 
Currently, if we have to return errors using the format
'return nil, error', we must do it manually. Since this error
return method is described in our Lua coding style, it makes sense
to create a function that will return an error in this format.
This patch creates mentioned function.

Needed for #4390
Gerold103 pushed a commit that referenced this issue Aug 1, 2019
@ImeevMA @Gerold103
sql: rework error handling in box.execute()
5278926 
In accordance with the Lua coding style in Tarantool, all errors
returned in Lua should be returned using 'return nil, error'.
However, box.execute() throws an exception in case of an error.
This patch causes box.execute() to return an error, as described
in the coding style.

Closes #4390
kyukhin pushed a commit that referenced this issue Aug 2, 2019
@ImeevMA @kyukhin
lua: new function luaT_push_nil_and_error()
7b35795 
Currently, if we have to return errors using the format
'return nil, error', we must do it manually. Since this error
return method is described in our Lua coding style, it makes sense
to create a function that will return an error in this format.
This patch creates mentioned function.

Needed for #4390
@kyukhin kyukhin closed this as completed in 98e29c0 Aug 2, 2019
@kyukhin kyukhin added feature A new functionality bug Something isn't working tmp and removed bug Something isn't working feature A new functionality labels Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImeevMA ImeevMA

Labels
bug Something isn't working refactoring Code refactoring sql
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@Totktonada @ImeevMA @kyukhin