Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'tarantool delayed_box_cfg.lua' stays after tests #4600

Closed
Gerold103 opened this issue Oct 30, 2019 · 0 comments
Closed

'tarantool delayed_box_cfg.lua' stays after tests #4600

Gerold103 opened this issue Oct 30, 2019 · 0 comments
Labels
bug Something isn't working flaky test qa Issues related to tests or testing subsystem
Milestone
2.2.2

Comments

@Gerold103
Copy link
Collaborator

Run the tests and in the end observe:

$ ps aux | grep tara
gerold            1979   0.0  0.0  4268056    804 s003  S+   10:58PM   0:00.00 grep tara
gerold             538   0.0  0.1  4793036   9044   ??  Ss   10:57PM   0:00.13 tarantool delayed_box_cfg.lua <running>

Somebody didn't stop delayed_box_cfg.lua.
@kyukhin kyukhin added bug Something isn't working qa Issues related to tests or testing subsystem labels Nov 8, 2019
@kyukhin kyukhin added this to the 2.2.2 milestone Nov 8, 2019
Totktonada added a commit that referenced this issue Nov 15, 2019
@Totktonada
test: ensure instances are stopped in tctl test
bdd0329 
The problem appears after 6c627af
('test: tarantoolctl: verify delayed box.cfg()'), where the test case
was changed and it doesn't more assume an error at the instance start.
So we need to stop it to prevent a situation when instances are stays
after `make test`.

Fixes #4600.
Totktonada added a commit that referenced this issue Nov 15, 2019
@Totktonada
test: ensure instances are stopped in tctl test
84ea1b9 
The problem appears after 6c627af
('test: tarantoolctl: verify delayed box.cfg()'), where the test case
was changed and it doesn't more assume an error at the instance start.
So we need to stop it to prevent a situation when instances are stay
after `make test`.

Fixes #4600.
Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

(cherry picked from commit 8d363c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working flaky test qa Issues related to tests or testing subsystem
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
2 participants
@Gerold103 @kyukhin