Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the existing tests in LuaJIT suite #4655

Closed
igormunkin opened this issue Nov 27, 2019 · 1 comment
Closed

Adjust the existing tests in LuaJIT suite #4655

igormunkin opened this issue Nov 27, 2019 · 1 comment
Labels
feature A new functionality qa Issues related to tests or testing subsystem
Milestone
2.4.1

Comments

@igormunkin
Copy link
Collaborator

All existing tests in LuaJIT suite seem to be written according to the current Lua style guide and violate several practices mentioned by @Totktonada in the review:

  • Use local for variables (tap, test).
  • Use os.exit(test:check() and 0 or 1) at the end.

Furthermore, the naming of all files doesn't respect to the one we agreed some time ago and dumped in tarantool/doc#1004.

Consider adjusting the chunks within this suite regarding remarks above.

I see this as a good issue to dive into our LuaJIT suite prior to #4064 and #4473.
avtikhon added a commit that referenced this issue Dec 12, 2019
@avtikhon
luajit tests: cleanup
5018f5f 
Cleaned up the tests at Luajit, bumped its version.

Close #4655
avtikhon added a commit that referenced this issue Dec 16, 2019
@avtikhon
luajit tests: cleanup
ba71647 
Cleaned up the tests at Luajit, bumped its version.

Close #4655
@kyukhin kyukhin added qa Issues related to tests or testing subsystem feature A new functionality labels Jan 16, 2020
@kyukhin kyukhin added this to the 2.4.1 milestone Jan 16, 2020
avtikhon added a commit that referenced this issue Feb 27, 2020
@avtikhon
luajit tests: cleanup
c2820ad 
Cleaned up the tests at Luajit, bumped its version.

Close #4655
avtikhon added a commit that referenced this issue Mar 20, 2020
@avtikhon
luajit tests: cleanup
41a5398 
Cleaned up the tests at Luajit, bumped its version.

Close #4655
avtikhon added a commit that referenced this issue Mar 20, 2020
@avtikhon
luajit tests: cleanup
be41f96 
Cleaned up the tests at Luajit, bumped its version.

Close #4655
@igormunkin
Copy link
Collaborator Author

Fixed in tarantool/luajit in tarantool/luajit@cf84758. The submodule was updated in tarantool in 2.4.0-121-g3c6416291 (3c64162), 2.3.1-74-g637db97b2 (637db97), 2.2.2-67-gddd3ce096 (ddd3ce0), 1.10.5-32-gd57146a21 (d57146a).

@ligurio ligurio mentioned this issue Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new functionality qa Issues related to tests or testing subsystem
Projects
None yet
Milestone
2.4.1
Development

No branches or pull requests
2 participants
@igormunkin @kyukhin