Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box.cfg should configure some parameters together, atomically #4714

Open
Gerold103 opened this issue Dec 27, 2019 · 1 comment
Open

Box.cfg should configure some parameters together, atomically #4714

Gerold103 opened this issue Dec 27, 2019 · 1 comment
Labels
bug Something isn't working config replication

Comments

@Gerold103
Copy link
Collaborator

After #3186 we have a new setting: replication_anon. It is a flag affecting replication setting. Consider the problem we have now: assume, we update both replication and replication_anon. Sometimes it is not possible to update them in one box.cfg without 'surprising' behaviour. Below I describe what happens when we update replication and replication_anon depending on the anon initial value.

  • replication_anon is changed true -> false
    • If we change anon before replication, then it will try to deanonymize the old replication before applying the new one. That is clearly a not expected behaviour;
    • If we change anon after replication, then it is not an error really, but it will connect to the new replication anonymously first, and then will try to execute deanon. Although it could have connected normally from the beginning.
  • replication_anon is changed false -> true (Add a way to remove a replica from cluster space and make it anonymous #4708)
    • If we change anon before replication, then it will anonymize the old replication, and only then it will drop it and connect to the new one. Again, that is not a real error, but just unnecessary work. It could just drop the old replication.
    • If we change anon after replication, then it will connect to the new replication normally, and then will try to anonymize it. This is wrong. Because normal join can fail due to lack of ids, for example. And this is unnecessary work.
@Gerold103 Gerold103 added bug Something isn't working replication labels Dec 27, 2019
@kyukhin kyukhin added this to the 2.3.2 milestone Jan 14, 2020
@kyukhin kyukhin modified the milestones: 2.3.2, 2.3.3 Apr 21, 2020
@Totktonada
Copy link
Member

The expected behaviour would be IMHO:

@kyukhin kyukhin modified the milestones: 2.3.3, 2.4.3 Jun 10, 2020
@kyukhin kyukhin modified the milestones: 2.4.3, wishlist Oct 23, 2020
@kyukhin kyukhin removed this from the wishlist milestone Sep 20, 2022
@Mons Mons added the config label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working config replication
Projects
None yet
Development

No branches or pull requests

4 participants