Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab-ci: add Catalina as OSX 15 #4873

Closed
avtikhon opened this issue Apr 9, 2020 · 1 comment
Closed

gitlab-ci: add Catalina as OSX 15 #4873

avtikhon opened this issue Apr 9, 2020 · 1 comment
Assignees

Comments

@avtikhon
Copy link
Contributor

avtikhon commented Apr 9, 2020

Tarantool version:

OS version:

Bug description:

Steps to reproduce:

Optional (but very desirable):

  • coredump
  • backtrace
  • netstat
avtikhon added a commit that referenced this issue Apr 9, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
otherwise it doesn't have the path to brew installed packages.

Close #4873
@avtikhon avtikhon added this to ON REVIEW in Quality Assurance Apr 9, 2020
@avtikhon avtikhon self-assigned this Apr 10, 2020
avtikhon added a commit that referenced this issue Apr 11, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
otherwise it doesn't have the path to brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 13, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
otherwise it doesn't have the path to brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 13, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
otherwise it doesn't have the path to brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 13, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
otherwise it doesn't have the path to brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 13, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
otherwise it doesn't have the path to brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 13, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Close #4873
avtikhon added a commit that referenced this issue Apr 13, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /etc/profile to setup paths in
invironment by special tool for it 'path_helper', otherwise it doesn't
have the path to brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 13, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /usr/libexec/path_helper tool
to setup paths in environment for brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 13, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /usr/libexec/path_helper tool
to setup paths in environment for brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 13, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /usr/libexec/path_helper tool
to setup paths in environment for brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 14, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /usr/libexec/path_helper tool
to setup paths in environment for brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 14, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /usr/libexec/path_helper tool
to setup paths in environment for brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 14, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /usr/libexec/path_helper tool
to setup paths in environment for brew installed packages.

Close #4873
@avtikhon avtikhon removed this from ON REVIEW in Quality Assurance Apr 17, 2020
avtikhon added a commit that referenced this issue Apr 28, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /usr/libexec/path_helper tool
to setup paths in environment for brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 28, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /usr/libexec/path_helper tool
to setup paths in environment for brew installed packages.

Close #4873
@avtikhon
Copy link
Contributor Author

Need fixes from #4885, even additionally the same:

/Users/tntmac04.tarantool.i/tnt/src/box/box.cc:1459:1: error: 'box_session_push' is missing exception specification '__attribute__((nothrow))' [-Werror,-Wmissing-exception-spec]
box_session_push(const char *data, const char *data_end)
^
                                                         __attribute__((nothrow))
/Users/tntmac04.tarantool.i/tnt/src/box/box.h:472:1: note: previous declaration is here
box_session_push(const char *data, const char *data_end);
^
1 error generated.
diff --git a/src/box/box.cc b/src/box/box.cc
index 8454299f8..43219545e 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -1455,7 +1455,7 @@ box_sequence_reset(uint32_t seq_id)
        return sequence_data_delete(seq_id);
 }
 
-int
+API_EXPORT int
 box_session_push(const char *data, const char *data_end)
 {
        struct session *session = current_session();

avtikhon added a commit that referenced this issue Apr 28, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Added to OSX 10.15 additional call to /usr/libexec/path_helper tool
to setup paths in environment for brew installed packages.

Close #4873
avtikhon added a commit that referenced this issue Apr 30, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Close #4873
@avtikhon avtikhon added this to ON REVIEW in Quality Assurance Apr 30, 2020
avtikhon added a commit that referenced this issue Apr 30, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Additional cleanup for 'box_return_mp', added API_EXPORT which defines
nothrow, so compiler warns or errors depending on the build options.

Part of #4885
Close #4873
avtikhon added a commit that referenced this issue Apr 30, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Additional cleanup for 'box_return_mp' and 'box_session_push',
added API_EXPORT which defines nothrow, compiler warns or errors
depending on the build options.

Part of #4885
Close #4873
avtikhon added a commit that referenced this issue Apr 30, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Additional cleanup for 'box_return_mp' and 'box_session_push',
added API_EXPORT which defines nothrow, compiler warns or errors
depending on the build options.

Part of #4885
Close #4873
kyukhin pushed a commit that referenced this issue May 8, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Additional cleanup for 'box_return_mp' and 'box_session_push',
added API_EXPORT which defines nothrow, compiler warns or errors
depending on the build options.

Part of #4885
Close #4873

(cherry picked from commit 76157ef)
kyukhin pushed a commit that referenced this issue May 8, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Additional cleanup for 'box_return_mp' and 'box_session_push',
added API_EXPORT which defines nothrow, compiler warns or errors
depending on the build options.

Part of #4885
Close #4873

(cherry picked from commit 76157ef)
@kyukhin kyukhin closed this as completed in 76157ef May 8, 2020
kyukhin pushed a commit that referenced this issue May 8, 2020
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.

Additional cleanup for 'box_return_mp' and 'box_session_push',
added API_EXPORT which defines nothrow, compiler warns or errors
depending on the build options.

Part of #4885
Close #4873

(cherry picked from commit 76157ef)
@avtikhon avtikhon moved this from ON REVIEW to DONE in Quality Assurance May 8, 2020
@avtikhon avtikhon removed this from DONE in Quality Assurance May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant