console tarantool ignores -i flag in case stdin is not a tty. #5064

OKriw · 2020-06-09T14:06:38Z

Tarantool version:
all
OS version:
all
Bug description:
When we executing some_command | tarantool -i. -i flag will be ignored, and command will be pars not by console.
Steps to reproduce:
Will be easy to reproduce after #4317 will be fixed.

Totktonada · 2020-06-09T15:15:47Z

Reproducer:

$ echo 42 | tarantool -i
LuajitError: stdin:1: unexpected symbol near '42'
fatal error, exiting the event loop

Expected:

$ echo 42 | tarantool -i
Tarantool 2.5.0-130-ge3cf64a6c
type 'help' for interactive help
tarantool> 42
---
- 42
...

tarantool> $

-i should have precedence over isatty() as in vanilla luajit.

Not sure what behaviour should be for tarantool -i -.

When using interactive console(stdin) instead of \set delimiter <delimiter> with "\", "\" in the end if line can be used. Works on server/client side. Local console is impossible to test with a pipe or tatantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (#5064). To overload this check end test the local console isatty lib was added.

When using interactive console(stdin) instead of \set delimiter <delimiter> with "\", "\" in the end if line can be used. Works on both server/client side. Local console is impossible to test with a pipe or tatantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (#5064). To overload this check and test the local console isatty lib was added.

When using interactive console one has to explicitly set delimiter different from newline ('\n') symbol before this patch. The changes make possible to split console input into multiple lines via backslash ('\\') at the end of the line instead of setting a delimiter. Local console is impossible to test with a pipe or tatantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (#5064). To overload this check and test the local console patch adds isatty lib. Closes #4317

When using interactive console(stdin) instead of \set delimiter <delimiter> with "\", "\" in the end if line can be used. Works on both server/client side. Local console is impossible to test with a pipe or tarantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (#5064). To overload this check and test the local console isatty lib was added.

When using interactive console(stdin) instead of \set delimiter <delimiter> with "\", "\" in the end if line can be used. Works on both server/client side. Local console is impossible to test with a pipe or tarantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (tarantool#5064). To overload this check and test the local console isatty lib was added.

@TarantoolBot

Local console is impossible to test with a pipe or tarantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (tarantool#5064). To overload this check and test the local console isatty lib was added. Co-Authored-By: Olga <arkholga@tarantool.org> Closes tarantool#4317 @TarantoolBot document Title: introduce line carrying slash When using interactive console(stdin) instead of `\set delimiter "\"`, slash at the end of the line can be used. Works on both server and client side. Consider the example: ``` tarantool> a = 10 \ > + 12 --- ... tarantool> a --- - 22 ... ```

@TarantoolBot

Local console is impossible to test with a pipe or tarantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (tarantool#5064). To overload this check and test the local console isatty lib was added. Co-authored-by: Olga <arkholga@tarantool.org> Closes tarantool#4317 @TarantoolBot document Title: introduce line carrying slash When using interactive console(stdin) instead of `\set delimiter "\"`, slash at the end of the line can be used. Works on both server and client side. Consider the example: ``` tarantool> a = 10 \ > + 12 --- ... tarantool> a --- - 22 ... ```

@TarantoolBot

Local console is impossible to test with a pipe or tarantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (tarantool#5064). To overload this check and test the local console isatty lib was added. Co-authored-by: Olga <arkholga@tarantool.org> Closes tarantool#4317 @TarantoolBot document Title: introduce line carrying slash When using interactive console(stdin) instead of `\set delimiter "\"`, slash at the end of the line can be used. Works on both server and client side. Consider the example: ``` tarantool> a = 10 \ > + 12 --- ... tarantool> a --- - 22 ... ```

@TarantoolBot

Local console is impossible to test with a pipe or tarantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (tarantool#5064). To overload this check and test the local console isatty lib was added. Co-authored-by: Olga <arkholga@tarantool.org> Closes tarantool#4317 @TarantoolBot document Title: introduce line carrying slash When using interactive console(stdin) instead of `\set delimiter "\"`, slash at the end of the line can be used. Works on both server and client side. Consider the example: ``` tarantool> a = 10 \ > + 12 --- ... tarantool> a --- - 22 ... ``` FreeBSD treats escaped chars differently than linux, thus when using printf the escaping must be escaped too. For example: ```BSD ~ printf "local a = 0 \\\\\nfor i = 1, 10 do\\\na = a + i\\\nend \\\\\nprint(a)" | | LD_PRELOAD=./test/libisatty.so ./src/tarantool ``` instead of ```linux ~ printf "local a = 0 \\\nfor i = 1, 10 do\na = a + i\nend \\\nprint(a)" | | LD_PRELOAD=./test/libisatty.so ./src/tarantool ```

@TarantoolBot

Local console is impossible to test with a pipe or tarantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (tarantool#5064). To overload this check and test the local console isatty lib was added. Co-authored-by: Olga <arkholga@tarantool.org> Closes tarantool#4317 @TarantoolBot document Title: introduce line carrying slash When using interactive console(stdin) instead of `\set delimiter "\"`, slash at the end of the line can be used. Works on both server and client side. Consider the example: ``` tarantool> a = 10 \ > + 12 --- ... tarantool> a --- - 22 ... ``` FreeBSD treats escaped chars differently than linux, thus when using printf the escaping must be escaped too. For example: ```BSD ~ printf "local a = 0 \\\\\nfor i = 1, 10 do\\\na = a + i\\\nend \\\\\nprint(a)" | | LD_PRELOAD=./test/libisatty.so ./src/tarantool ``` instead of ```linux ~ printf "local a = 0 \\\nfor i = 1, 10 do\na = a + i\nend \\\nprint(a)" | | LD_PRELOAD=./test/libisatty.so ./src/tarantool ```

@TarantoolBot

Local console is impossible to test with a pipe or tarantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (tarantool#5064). To overload this check and test the local console isatty lib was added. Co-authored-by: Olga Arkhangelskaia <arkholga@tarantool.org> Closes tarantool#4317 @TarantoolBot document Title: introduce line carrying slash When using interactive console(stdin) instead of `\set delimiter "\"`, slash at the end of the line can be used. Works on both server and client side. Consider the example: ``` tarantool> a = 10 \ > + 12 --- ... tarantool> a --- - 22 ... ``` FreeBSD treats escaped chars differently than linux, thus when using printf the escaping must be escaped too. For example: ```BSD ~ printf "local a = 0 \\\\\nfor i = 1, 10 do\\\na = a + i\\\nend \\\\\nprint(a)" | | LD_PRELOAD=./test/libisatty.so ./src/tarantool ``` instead of ```linux ~ printf "local a = 0 \\\nfor i = 1, 10 do\na = a + i\nend \\\nprint(a)" | | LD_PRELOAD=./test/libisatty.so ./src/tarantool ```

The interactive mode has been overruled by isatty check and is no more. Now results of another command can be handled by tarantool. For example: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... tarantool> $ ``` NO_DOC=bugfix Closes tarantool#5064

@TarantoolBot

When using interactive console(stdin) instead of `\set delimiter '\'`, slash at the end of the line can be used. Works on both server and client side. Local console is impossible to test with a pipe or tarantool interactive mode. The problem with interactive mode (-i) is that the flag that sets it, does not influence the isatty() check, while startup script is executed (tarantool#5064). To overload this check and test the local console isatty lib was added. Co-authored-by: Olga Arkhangelskaia <arkholga@tarantool.org> Closes tarantool#4317 @TarantoolBot document Title: introduce line carrying slash Now we can use multiline commands with lines ending with '\' by default. Works only without a set delimiter. Consider the example: ``` tarantool> a = 10 \ > + 12 --- ... tarantool> a --- - 22 ... ```

The interactive mode has been overruled by isatty check and is no more. Now results of another command can be handled by tarantool. For example: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... tarantool> $ ``` NO_DOC=bugfix Closes tarantool#5064

Inspired by tarantoolgh-5064, that breaks the previous version of the test on opensuse. When using `io.popen:write()` on tarantool with `-i` flag, it failed to run the command on opensuse. Needed for tarantool#5064 NO_DOC=test fix NO_TEST=test fix NO_CHANGELOG=test fix

The interactive mode has been overruled by isatty check and is no more. Now results of another command can be handled by tarantool. For example: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... tarantool> $ ``` Closes tarantool#5064 NO_DOC=bugfix

Inspired by tarantoolgh-5064, that breaks the previous version of the test on opensuse. When using `io.popen:write()` on tarantool with `-i` flag, it failed to run the command on opensuse. It happend because before tarantoolgh-5064 patch it used to employ `luaL_loadfile()` that interprets EOF as the end of the command, while when it is loaded as a string opensuse expects it to end with '\'. Needed for tarantool#5064 NO_DOC=test fix NO_TEST=test fix NO_CHANGELOG=test fix

The interactive mode has been overruled by isatty check and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... tarantool> $ ``` Closes tarantool#5064 NO_DOC=bugfix

Inspired by tarantoolgh-5064, that breaks the previous version of the test on opensuse. When using `io.popen:write()` on tarantool with `-i` flag, it failed to run the command on opensuse. This happened because before tarantoolgh-5064 patch it used to employ `luaL_loadfile()` that interprets EOF as the end of the command, while when it is loaded as a string opensuse expects it to end with '\'. Needed for tarantool#5064 NO_DOC=test fix NO_TEST=test fix NO_CHANGELOG=test fix

The interactive mode has been overruled by isatty check and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... tarantool> $ ``` Closes tarantool#5064 NO_DOC=bugfix

Inspired by tarantoolgh-5064, that breaks the previous version of the test on openSUSE. When using `io.popen:write()` on tarantool with `-i` flag, it failed to run the command on openSUSE. This happened because before tarantoolgh-5064 patch it used to employ `luaL_loadfile()` that interprets EOF as the end of the command, while when it is loaded as a string openSUSE expects it to end with '\n'. Needed for tarantool#5064 NO_DOC=test fix NO_TEST=test fix NO_CHANGELOG=test fix

The interactive mode has been overruled by isatty check and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... tarantool> $ ``` Closes tarantool#5064 NO_DOC=bugfix

The interactive mode has been ignored when stdin was not a tty and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... tarantool> $ ``` Closes tarantool#5064 NO_DOC=bugfix

The interactive mode has been ignored when stdin was not a tty and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... ``` Closes tarantool#5064 NO_DOC=bugfix

Inspired by tarantoolgh-5064, that breaks the previous version of the test on openSUSE. When using `io.popen:write()` on tarantool with `-i` flag, it failed to run the command on openSUSE. This happened because before tarantoolgh-5064 patch it used to employ `luaL_loadfile()` that interprets EOF as the end of the command, while when it is loaded as a string openSUSE expects it to end with '\n'. Needed for tarantool#5064 NO_DOC=test fix NO_TEST=test fix NO_CHANGELOG=test fix

The interactive mode has been ignored when stdin was not a tty and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... ``` Closes tarantool#5064 NO_DOC=bugfix

Inspired by tarantoolgh-5064, that breaks the previous version of the test on openSUSE. When using `io.popen:write()` on tarantool with `-i` flag, it failed to run the command on openSUSE. This happened because before tarantoolgh-5064 patch it used to employ `luaL_loadfile()` that interprets EOF as the end of the command, while when it is loaded as a string openSUSE expects it to end with '\n'. Needed for tarantool#5064 NO_DOC=test fix NO_TEST=test fix NO_CHANGELOG=test fix

The interactive mode has been ignored when stdin was not a tty and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... ``` Closes tarantool#5064 NO_DOC=bugfix

Inspired by gh-5064, that breaks the previous version of the test on openSUSE. When using `io.popen:write()` on tarantool with `-i` flag, it failed to run the command on openSUSE. This happened because before gh-5064 patch it used to employ `luaL_loadfile()` that interprets EOF as the end of the command, while when it is loaded as a string openSUSE expects it to end with '\n'. Needed for #5064 NO_DOC=test fix NO_TEST=test fix NO_CHANGELOG=test fix

The interactive mode has been ignored when stdin was not a tty and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... ``` Closes #5064 NO_DOC=bugfix

Inspired by tarantoolgh-5064, that breaks the previous version of the test on openSUSE. When using `io.popen:write()` on tarantool with `-i` flag, it failed to run the command on openSUSE. This happened because before tarantoolgh-5064 patch it used to employ `luaL_loadfile()` that interprets EOF as the end of the command, while when it is loaded as a string openSUSE expects it to end with '\n'. Needed for tarantool#5064 NO_DOC=test fix NO_TEST=test fix NO_CHANGELOG=test fix

The interactive mode has been ignored when stdin was not a tty and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... ``` Closes tarantool#5064 NO_DOC=bugfix

The interactive mode has been ignored when stdin was not a tty and is no more. Now results of another command can be handled by tarantool. Before the patch: ``` $ echo 42 | tarantool -i LuajitError: stdin:1: unexpected symbol near '42' fatal error, exiting the event loop ``` After the patch: ``` $ echo 42 | tarantool -i Tarantool 2.5.0-130-ge3cf64a6c type 'help' for interactive help tarantool> 42 --- - 42 ... ``` Closes #5064 NO_DOC=bugfix (cherry picked from commit 9965e3f)

Totktonada added app bug Something isn't working labels Jun 9, 2020

kyukhin added this to the wishlist milestone Sep 16, 2020

Totktonada mentioned this issue Jan 13, 2021

tarantool -e always enters interactive mode when stdin is a tty #5040

Closed

artemreyt self-assigned this Jan 13, 2021

Totktonada mentioned this issue Dec 30, 2021

lua: avoid tarantool console quit if sigint signal sending #6633

Merged

Totktonada unassigned artemreyt Dec 30, 2021

kyukhin added the teamL label Jun 15, 2022

kyukhin removed this from the wishlist milestone Jun 15, 2022

Lord-KA mentioned this issue Jul 4, 2022

console: configure continuation #7347

Merged

Lord-KA mentioned this issue Jul 4, 2022

console: fix -i being overruled by !isatty() #7357

Merged

igormunkin closed this as completed in #7357 Aug 9, 2022

Lord-KA mentioned this issue Aug 10, 2022

Remove ERRINJ_STDIN_ISATTY #7554

Closed

Buristan added 5sp labels Aug 17, 2022

igormunkin assigned Lord-KA Sep 15, 2022

igormunkin added 2.11 Target is 2.11 and all newer release/master branches and removed 5sp labels Sep 15, 2022

Totktonada mentioned this issue Jan 24, 2023

doc: cleanup released changelogs #8191

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

console tarantool ignores -i flag in case stdin is not a tty. #5064

console tarantool ignores -i flag in case stdin is not a tty. #5064

OKriw commented Jun 9, 2020

Totktonada commented Jun 9, 2020

console tarantool ignores -i flag in case stdin is not a tty. #5064

console tarantool ignores -i flag in case stdin is not a tty. #5064

Comments

OKriw commented Jun 9, 2020

Totktonada commented Jun 9, 2020