Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: panic in case when "log" is incorrectly specified #5130

Closed
olegrok opened this issue Jul 2, 2020 · 0 comments
Closed

log: panic in case when "log" is incorrectly specified #5130

olegrok opened this issue Jul 2, 2020 · 0 comments
Assignees
@cyrillos
Labels
bug Something isn't working crash
Milestone
2.5.2

Comments

@olegrok
Copy link
Collaborator

olegrok commented Jul 2, 2020 

Tarantool 2.5.0-167-g02cca3522
type 'help' for interactive help
tarantool> box.cfg{log = ' syslog:identity=test'}
---
- error: 'Incorrect value for option ''log'': expecting a file name or a prefix, such
    as ''|'', ''pipe:'', ''syslog:'''
...

tarantool> require('log').cfg{log = ' syslog:identity=test'}
IllegalParams: expecting a file name or a prefix, such as '|', 'pipe:', 'syslog:'
failed to initialize logging subsystem
➜  tarantool git:(master) ✗ echo $?
1

Expected the same error as for box.cfg.log without application termination.
@olegrok olegrok changed the title log: panic in case when "log" is an incorrectly specified log: panic in case when "log" is incorrectly specified Jul 4, 2020
@kyukhin kyukhin added this to the 2.5.3 milestone Aug 14, 2020
@kyukhin kyukhin added bug Something isn't working crash labels Aug 14, 2020
olegrok added a commit that referenced this issue Sep 8, 2020
@olegrok
lua: fix panic in case when log.log incorrecly specified
3a0c657 
This patch makes log{log = ...} behaviour the same as in case with
box.cfg{log = ...} and fix panic if "log" is incorrectly specified
option. For such purpose we export "say_parse_logger_type"
function and use for logger type validation and logger type
parsing.

Closes #5130
olegrok added a commit that referenced this issue Sep 8, 2020
@olegrok
lua: fix panic in case when log.cfg.log incorrecly specified
8caca29 
This patch makes log.cfg{log = ...} behaviour the same as in case
with box.cfg{log = ...} and fix panic if "log" is incorrectly
specified option. For such purpose we export "say_parse_logger_type"
function and use for logger type validation and logger type
parsing.

Closes #5130
olegrok added a commit that referenced this issue Sep 9, 2020
@olegrok
lua: fix panic in case when log.cfg.log incorrecly specified
8eb5165 
This patch makes log.cfg{log = ...} behaviour the same as in
box.cfg{log = ...} and fixes panic if "log" is incorrectly
specified. For such purpose we export "say_parse_logger_type"
function and use for logger type validation and logger type
parsing.

Closes #5130
olegrok added a commit that referenced this issue Sep 9, 2020
@olegrok
lua: fix panic in case when log.cfg.log incorrecly specified
e5216f4 
This patch makes log.cfg{log = ...} behaviour the same as in
box.cfg{log = ...} and fixes panic if "log" is incorrectly
specified. For such purpose we export "say_parse_logger_type"
function and use for logger type validation and logger type
parsing.

Closes #5130
kyukhin pushed a commit that referenced this issue Sep 11, 2020
@olegrok @kyukhin
lua: fix panic in case when log.cfg.log incorrecly specified
f0fd2a9 
This patch makes log.cfg{log = ...} behaviour the same as in
box.cfg{log = ...} and fixes panic if "log" is incorrectly
specified. For such purpose we export "say_parse_logger_type"
function and use for logger type validation and logger type
parsing.

Closes #5130

(cherry picked from commit 85f19a8)
@kyukhin kyukhin modified the milestones: 2.5.3, 2.5.2 Oct 12, 2020
@Vigor-jpg Vigor-jpg mentioned this issue Apr 17, 2022
Open
@olegrok olegrok mentioned this issue Jul 20, 2022
Closed
@nshy nshy assigned nshy and cyrillos and unassigned cyrillos and nshy Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyrillos cyrillos

Labels
bug Something isn't working crash
Projects
None yet
Milestone
2.5.2
Development

No branches or pull requests
4 participants
@cyrillos @nshy @olegrok @kyukhin