Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix luacheck warnings in test/app #5454

Closed
ligurio opened this issue Oct 29, 2020 · 2 comments
Closed

Fix luacheck warnings in test/app #5454

ligurio opened this issue Oct 29, 2020 · 2 comments
Assignees
@ligurio
Labels
lua luacheck

Comments

@ligurio
Copy link
Member

ligurio commented Oct 29, 2020

No description provided.

@ligurio ligurio added the lua label Oct 29, 2020
@ligurio ligurio self-assigned this Oct 29, 2020
@ligurio ligurio mentioned this issue Oct 29, 2020
Closed
@Totktonada
Copy link
Member

Should we verify code for tarantool console with luacheck? I guess we can do it, but with relaxed restrictions about using local and maybe other tricks.

ligurio added a commit that referenced this issue Nov 19, 2020
@ligurio @Gerold103 @igormunkin
Fix luacheck warnings in test/app
a49236b 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 15, 2020
@ligurio @Gerold103 @igormunkin
Fix luacheck warnings in test/app
8e9d92e 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 15, 2020
@ligurio @Gerold103 @igormunkin
Fix luacheck warnings in test/app
6b07961 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 16, 2020
@ligurio @Gerold103 @igormunkin
Fix luacheck warnings in test/app
5dbbe5e 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 16, 2020
@ligurio @Gerold103 @igormunkin
Fix luacheck warnings in test/app
5deea47 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 16, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
ed1e5f4 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 16, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
234ebec 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 16, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
418bdaa 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 16, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
61ed337 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
@ligurio
Copy link
Member Author

ligurio commented Dec 16, 2020

[Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/app-tap and test/app
https://lists.tarantool.org/pipermail/tarantool-patches/2020-December/021385.html

ligurio added a commit that referenced this issue Dec 21, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
1b9b587 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 22, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
54d3a6b 
Part of #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 22, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
30ee5ff 
Closes #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 24, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
50941c1 
Closes #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 24, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
251bb4a 
Closes #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 24, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
778eafd 
Closes #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
ligurio added a commit that referenced this issue Dec 24, 2020
@ligurio @Gerold103 @igormunkin
luacheck: fix warnings in test/app
cd5ee69 
Closes #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
kyukhin pushed a commit that referenced this issue Dec 25, 2020
@ligurio @Gerold103
@igormunkin @kyukhin
luacheck: fix warnings in test/app
44362f6 
Closes #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
kyukhin pushed a commit that referenced this issue Dec 25, 2020
@ligurio @Gerold103
@igormunkin @kyukhin
luacheck: fix warnings in test/app
41ba388 
Closes #5454

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ligurio ligurio

Labels
lua luacheck
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Totktonada @ligurio