Fix luacheck warnings for luajit tests #5470
Comments
|
@ligurio, besides the warning suppression there is also the patch with LGTM in LuaJIT repo (tarantool/luajit@5bc0393). I guess you've missed it, since this one doesn't refer the original issue. @kyukhin, can we apply it out of order? |
|
@igormunkin Yeah, missed it. I'll ask Kirill to merge it. |
|
It was pushed in 2.7.0-5-gd3b1c4817. What actions are expected within this issue? Remove the test suite from the exclusions list in .luacheckrc? |
|
@Totktonada Yep. |
|
There is also c9653cb to be applied. |
ligurio
changed the title
|
Blocked by #5631 |
|
@ligurio, I've moved all LuaJIT-related static analysis into luajit repo (here is the WIP branch). I'll take this issue on me and it will be closed with the patches made for #4862. The fixes for #5631 can be also found on the branch mentioned above. |
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Jan 30, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Fixes tarantool/tarantool#5631 Part of tarantool/tarantool#5470 Part of tarantool/tarantool#4862 Follows up tarantool/tarantol#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 2, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Fixes tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 2, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with upstream. The new target is a dependency for the root <test> target. Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 2, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Fixes tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 2, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with upstream. The new target is a dependency for the root <test> target. Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 2, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Fixes tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 2, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
that referenced
this issue
Feb 3, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 8, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Fixes tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 8, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Reviewed-by: Timur Safin <tsafin@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 9, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Fixes tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 9, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Reviewed-by: Timur Safin <tsafin@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 20, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Resolves tarantool/tarantool#5470 Part of tarantool/tarantool#4862 Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
that referenced
this issue
Feb 20, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Closes #5631 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
that referenced
this issue
Feb 20, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Closes #5631 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 25, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Resolves tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 25, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Resolves tarantool/tarantool#5470 Part of tarantool/tarantool#4862 Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
that referenced
this issue
Feb 25, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Closes #5631 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
that referenced
this issue
Feb 26, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Closes #5631 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 28, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Resolves tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 28, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Resolves tarantool/tarantool#5470 Part of tarantool/tarantool#4862 Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
that referenced
this issue
Feb 28, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Closes #5631 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 28, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Resolves tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org> (cherry picked from commit d9d5ab1)
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 28, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Resolves tarantool/tarantool#5470 Part of tarantool/tarantool#4862 Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org> (cherry picked from commit 6dd4724)
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 28, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Resolves tarantool/tarantool#5470 Part of tarantool/tarantool#4862 Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org> (cherry picked from commit 6dd4724)
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 28, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Resolves tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 28, 2021
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Resolves tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org> (cherry picked from commit d9d5ab1)
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Feb 28, 2021
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Resolves tarantool/tarantool#5470 Part of tarantool/tarantool#4862 Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org> (cherry picked from commit 6dd4724)
igormunkin
added a commit
that referenced
this issue
Feb 28, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Closes #5631 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org> (cherry picked from commit 07c83aa)
igormunkin
added a commit
that referenced
this issue
Feb 28, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Closes #5631 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org> (cherry picked from commit 07c83aa)
igormunkin
added a commit
that referenced
this issue
Feb 28, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Closes #5631 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org> (cherry picked from commit 07c83aa)
igormunkin
added a commit
that referenced
this issue
Feb 28, 2021
LuaJIT submodule is bumped to introduce the following changes: * test: run luacheck static analysis via CMake * test: fix warnings found with luacheck in misclib* * test: run LuaJIT tests via CMake * build: replace GNU Make with CMake * build: preserve the original build system Since LuaJIT build system is ported to CMake in scope of the changeset mentioned above, the module building the LuaJIT bundled in Tarantool is completely reworked. There is no option to build Tarantool against another prebuilt LuaJIT due to a91962c ('Until Bug#962848 is fixed, don't try to compile with external LuaJIT'), so all redundant options defining the libluajit to be used in Tarantool are dropped with the related auxiliary files. To run LuaJIT related tests or static analysis for Lua files within LuaJIT repository, <LuaJIT-test> and <LuaJIT-luacheck> targets are used respectively as a dependency of the corresponding Tarantool targets. As an additional dependency to run LuaJIT tests, prove[1] utility is required, so the necessary binary packages are added to the lists with build requirements. [1]: https://metacpan.org/pod/TAP::Harness#prove Closes #4862 Closes #5470 Closes #5631 Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
|
The issue is initally fixed in scope of tarantool/luajit@8fc103f and is fully resolved in scope of tarantool/luajit@6dd4724. The submodule was updated in tarantool in 2.8.0-82-g07c83aab5 (07c83aa), 2.7.1-73-gd112a4e6e (d112a4e), 2.6.2-70-g1b00de081 (1b00de0), 1.10.9-46-g5d25b860a (5d25b86). |
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Jun 16, 2022
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Resolves tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Jun 16, 2022
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Resolves tarantool/tarantool#5470 Part of tarantool/tarantool#4862 Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Jun 16, 2022
Since the regular static analysis has not been enabled for the test chunks in LuaJIT repository yet, the tests for recently implemented features still produce luacheck warnings. The most of the issues are fixed in scope of the commit 8fc103f ('test: fix warnings spotted by luacheck') and this patch fixes the remaining ones. Resolves tarantool/tarantool#5631 Part of tarantool/tarantool#4862 Part of tarantool/tarantool#5470 Follows up tarantool/tarantool#5187 Reported-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
igormunkin
added a commit
to tarantool/luajit
that referenced
this issue
Jun 16, 2022
This patch introduces a separate target to run luacheck against all Lua chunks within LuaJIT repository except those explicitly ignored in .luacheckrc. There is also a single additional change over the 'luajit' std defaults: to suppress all false positives related to <misc> namespace introduced in 5a61e1a ('misc: add C and Lua API for platform metrics'), this name is added to <read_globals> list. All Lua sources originally inherited from LuaJIT vanilla repository are ignored, to leave them coherent with the upstream. The new target is a dependency for the root <test> target. Resolves tarantool/tarantool#5470 Part of tarantool/tarantool#4862 Reviewed-by: Timur Safin <tsafin@tarantool.org> Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> Signed-off-by: Igor Munkin <imun@tarantool.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Blocked by #5631
The text was updated successfully, but these errors were encountered: